-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code navigation issue in WebStorm #24910
Comments
Also no navigation to |
I added the recent logs, it contains some Dart related exceptions. I don't have the newer options mentioned in https://docs.google.com/document/d/1s4PTof1x7RyxXYX1yO31ByvZsQoDMM7edFIW1SKP25U/edit?pli=1# for Dart Plugin version 15.0.1 |
I updated to
in the meantime, but still run into this issue. |
Verified that navigation on those tokens does not work. Got these exceptions out of 1.13.0_dev_7.12: 9:57:44 AM Throwable: Dart analysis server, SDK version 1.13.0-dev.7.12, server version 1.12.0, error: Task failed: GenerateLintsTask for source /usr/local/google/home/jwren/src/github/bwu_bind_html/lib/bwu_bind_html.dart |
@zoechi is this blocking you from moving to 1.13 to the extent that we have to provide a patch for 1.13? |
No, it's not blocking me. I'm on bleeding edge anyway (now 1.14.0-xxx). My WebStorm Event Log is full with these exceptions, |
Thanks. We will get it fixed in a 1.14 bleeding edge / dev build, and then take it from there depending on the general feedback. |
@jwren : are you still able to reproduce? |
@zoechi : these exceptions should be fixed with dart-lang/linter@83453a4 which was pulled into the SDK w/ 4b03a59. Please let me know if you see any other @scheglov : do you think these linter failures are the cause of the navigation issues? On the surface they seem unrelated...
|
OK, I guess this is fixed now. |
I'm still getting lots of these execptions
_
|
@zoechi : it looks like you've discovered another issue. Thanks! |
Background here: dart-lang/sdk#24910 The rub is we need to be careful in case nodes or tokens are null (for example when analyzing invalid source). BUG=24910 R=scheglov@google.com Review URL: https://codereview.chromium.org//1464173002 .
I don't get any exceptions from dart analyzer anymore after updating to the latest bleeding edge Dart version. The code navigation issue remains though. |
The latest build of the IDEA plugin include support for |
* Protects against errors in linting invalid source (#24910). * Adds `avoid_empty_else` lint rule (dart-lang/sdk#224936). R=brianwilkerson@google.com Review URL: https://codereview.chromium.org/1472403002 .
In this code file (https://github.com/bwu-dart/bwu_bind_html/blob/46720f24af481e1af97c103993f0802226355bf2/test/test_element.dart#L14-L14)
In this line
I can Ctrl+click on
allowHtml5
but not onNodeValidatorBuilder
The text was updated successfully, but these errors were encountered: