Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable decimal digits #403

Merged
merged 3 commits into from
Jul 6, 2015
Merged

Conversation

crowning-
Copy link

Reference: https://dashtalk.org/threads/enhanced-darkcoin-wallet-ui.1705/page-24#post-57501

People are confused by too much decimal digits, so I made this configurable with values from 2-8, default=2.

As a side effect we don't have the trouble to fit all digits into the already very crowded UI anymore. @snogcel will LOVE that :-)

Right now I only did this for the overview page, if you find other places where this makes sense (means where users normally don't cute & paste values) just drop me a note.

Configuration:
options

Look:
wallet

For now I kept the obsolete signatures of the copied methods in case we'll need them on other tabs...

@UdjinM6
Copy link

UdjinM6 commented Jul 6, 2015

I really like the idea but not the implementation, sorry.

I see no reason for function simpleFormat to exist - you could just use SeparatorStyle eq to separatorNever if don't want separators to appear. Though I don't really understand why would you want to. I would leave them in place. I guess that that's because you want to round stuff later but.. that's yet another "why?" from me :) I would prefer floor instead of round for money values and that can be done simply by chopping string. Another issue is that that kind of rounding doesn't work well with duffs.

On another note: I just figured out that formatWithUnit doesn't really work in the left side of overview page - it is a html now because of our styling so we need to implement roundHtmlWithUnit also.

@crowning-
Copy link
Author

No problem, I wasn't 100% happy with the implementation either, and chopping away the digits makes indeed stuff MUCH easier 👍

I'll merge this now without testing and do the usual tests later (after work).

@eduffield222
Copy link

Let me know when you guys are happy with this and I'll merge it

@crowning-
Copy link
Author

Tested okay, so if @UdjinM6 doesn't have additional proposals we can merge it.

@UdjinM6
Copy link

UdjinM6 commented Jul 6, 2015

Thanks for testing, @crowning- ! 👍 I'm fine with current state too so I guess you can merge it, @evan82

eduffield222 pushed a commit that referenced this pull request Jul 6, 2015
Configurable decimal digits
@eduffield222 eduffield222 merged commit f6a6d1b into dashpay:v0.12.0.x Jul 6, 2015
@crowning- crowning- deleted the Digits branch July 11, 2015 14:48
PastaPastaPasta added a commit that referenced this pull request Oct 26, 2024
…403, #418, #416, #449, #477, #563, #554, #615 (qt backports: part 2)

1a2c02a merge bitcoin-core/gui#615: If -prune=0 is set, Uncheck Prune on Intro page (Kittywhiskers Van Gogh)
3d5aca6 merge bitcoin-core/gui#554: Add and improve translator comments and tooltips for peers tab address fields (Kittywhiskers Van Gogh)
0c545ac merge bitcoin-core/gui#563: Remove network detection based on address in BIP21 (Kittywhiskers Van Gogh)
f088334 merge bitcoin-core/gui#477: Monospaced output in Console on macOS (Kittywhiskers Van Gogh)
694f3e9 merge bitcoin-core/gui#449: Restore "S" accelerator for "Start on system login" option (Kittywhiskers Van Gogh)
063ef3a merge bitcoin-core/gui#416: Add RPC setting (Kittywhiskers Van Gogh)
fa2f7ac merge bitcoin-core/gui#418: fix bitcoin-qt app categorization on apple silicon (Kittywhiskers Van Gogh)
594177d merge bitcoin-core/gui#403: Make paths to update Encryption and HD wallet statuses simpler (Kittywhiskers Van Gogh)
ba5ad1f merge bitcoin-core/gui#349: replace QDateTime::fromTime_t with QDateTime::fromSecsSinceEpoch (Kittywhiskers Van Gogh)
70d4e08 merge bitcoin-core/gui#317: Add Direction column to Peers Tab (Kittywhiskers Van Gogh)
0a5481c merge bitcoin-core/gui#354: Refactor open date range to use std::optional (Kittywhiskers Van Gogh)
17a7e9b merge bitcoin-core/gui#337: Use Regex Search in Apptests (Kittywhiskers Van Gogh)

Pull request description:

  ## Additional Information

  | `develop` (3a18f08)                                       | This PR                                                      |
  | ------------------------------------------------------------ | ------------------------------------------------------------ |
  | ![image](https://github.com/user-attachments/assets/e5d48b17-2eae-4e58-bbbf-6c011dc98c9c) | ![image](https://github.com/user-attachments/assets/fc47c1f1-d3c2-45dc-bdd5-2e94bc02489d) |
  | ![image](https://github.com/user-attachments/assets/e75bd85a-30a7-4e49-8a75-c8ce5090ba50) | ![image](https://github.com/user-attachments/assets/51fd865a-91fd-4742-b745-1cfb6866ae14) |

  ## Breaking changes

  None observed.

  ## Checklist

  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas (note: N/A)
  - [x] I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
  - [x] I have made corresponding changes to the documentation (note: N/A)
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK 1a2c02a

Tree-SHA512: d424a0ebe817c08a50c2455fea1c3bf798a1a53dd87bc9b71cd7173824d7892a83035f046dfccc85d1925b91705d4db7ac2a498e4299d91504a1a8306762e5b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants