-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer double count transfer cost in stealing #7036
No longer double count transfer cost in stealing #7036
Conversation
This reverts commit cfae9ee.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 6h 11m 48s ⏱️ - 1m 25s For more details on these failures, see this check. Results for commit 9c9438e. ± Comparison against base commit 1fd07f0. ♻️ This comment has been updated with latest results. |
assert ts.processing_on | ||
assert ts in ts.processing_on.long_running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov says this is not hit but I'd expect this to be hit by test_dont_steal_long_running_tasks
We should probably look at that test, maybe some test assumption is no longer true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, test_dont_steal_long_running_tasks
is pretty meaningless. I believe something went wrong during a refactoring of that test. It only asserts that long_tasks are only "executed" once, i.e. they are not rescheduled. This is entirely irrelevant for stealing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this test was already this way I suggest to set this out of scope for this PR. I might be able to address this with #7030
All failing tests are known offenders except of |
Co-authored-by: fjetter <fjetter@users.noreply.github.com>
pre-commit run --all-files