Example.com still part of the callbacks in the AppClient Allowed callback URLs #454
Labels
priority: low
status: not-picked-yet
At the moment we have not picked this item. Anyone can pick it up
type: bug
Something isn't working
Comments
dlpzx
added
type: bug
|
@gmuslia thanks for raising this issue and providing the reason. I know what you are referring to, but if you have availability you can go ahead and fix it in a PR. Since it is a patch it can be opened to the main branch and it will be part of the next patch release. |
|
Thank you, I just submit the PR @dlpzx. Have tested locally the same scenario and it does the full-text match correctly this time. |
dlpzx
pushed a commit
that referenced
this issue
May 17, 2023
### Feature or Bugfix - BugFix ### Detail - In line (https://github.com/awslabs/aws-dataall/blob/13a2fc082694600a0dacaa7e88d0d61ec950d753/deploy/configs/cognito_urls_config.py#L61) It checks for example.com where instead the right callback to check is ```https://example.com``` and that's why it doesn't get replaced during the configuration phase. ### Relates - #454 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/awslabs/aws-dataall/blob/13a2fc082694600a0dacaa7e88d0d61ec950d753/deploy/configs/cognito_urls_config.py#L61
It checks for
example.comwhere instead the right callback to check ishttps://example.comand that's why it doesn't get replaced during the configuration phase.The text was updated successfully, but these errors were encountered: