-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OpenSearch Serverless #292
Support OpenSearch Serverless #292
Conversation
- Add OpenSearch Serverless stack & corresponding feature flag - Update client request signature ("aoss"/"es") and create service SSM parameter - Update domain / collection references - Add ECS task role to OpenSearch Serverless principals - Update CDK library to latest (2.61.1) - Update Pipeline CodeBuild image to STANDARD_6_0 with latest node version to use latest CDK - Pass VPC endpoints security group to OpenSearch Serverless stack - Update template_cdk.json - Add monitoring
- Make sure either OS or AOSS alarms are created - Build hostname based on collection id to avoid CDK token manipulation - Fix typo
- Skip calling /GET info for serverless opensearch collection - Remove unused imports
- Remove alarm action parameter - Fix OS/AOSS stack inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this seems to work fine, I think we can go without it:)
Approved. Great job! 👍
Thanks for the review @nikpodsh! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging we can include what we discussed yesterday around existing customers that want to take advantage of this feature.
How do we migrate the information from OpenSearch non-serverless to serverless. At least we need to provide some info
Thank you for cleaning up the unnecessary packages from the CICD pipeline! The testing in v1m5m0 branch is ready, so you can go ahead and merge your changes. Great contribution @kukushking 🚀 |
### Feature or Bugfix - Feature ### Detail - Add OpenSearch Serverless stack & corresponding feature flag - Update client request signature ("aoss"/"es") and create service SSM parameter - Update domain / collection references - Add ECS task role to OpenSearch Serverless principals - Update CDK library to latest (2.61.1) - Update Pipeline CodeBuild image to `AMAZON_LINUX_2_4` with latest node version to use latest CDK and remove unnecessary packages - Pass VPC endpoints security group to OpenSearch Serverless stack - Update template_cdk.json - Add monitoring By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
### Feature or Bugfix - V1.5.0 Features. Check each PR for a complete description of the feature. ### Detail - #292 - #355 - #337 - #427 - #431 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: kukushking <kukushkin.anton@gmail.com> Co-authored-by: Dariusz Osiennik <osiend@amazon.com> Co-authored-by: Noah Paige <69586985+noah-paige@users.noreply.github.com> Co-authored-by: Dennis Goldner <107395339+degoldner@users.noreply.github.com>
Feature or Bugfix
Detail
AMAZON_LINUX_2_4
with latest node version to use latest CDK and remove unnecessary packagesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.