Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenSearch Serverless #292

Merged
merged 9 commits into from
Feb 17, 2023

Conversation

kukushking
Copy link
Contributor

@kukushking kukushking commented Feb 3, 2023

Feature or Bugfix

  • Feature

Detail

  • Add OpenSearch Serverless stack & corresponding feature flag
  • Update client request signature ("aoss"/"es") and create service SSM parameter
  • Update domain / collection references
  • Add ECS task role to OpenSearch Serverless principals
  • Update CDK library to latest (2.61.1)
  • Update Pipeline CodeBuild image to AMAZON_LINUX_2_4 with latest node version to use latest CDK and remove unnecessary packages
  • Pass VPC endpoints security group to OpenSearch Serverless stack
  • Update template_cdk.json
  • Add monitoring

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Add OpenSearch Serverless stack & corresponding feature flag
- Update client request signature ("aoss"/"es") and create service SSM parameter
- Update domain / collection references
- Add ECS task role to OpenSearch Serverless principals
- Update CDK library to latest (2.61.1)
- Update Pipeline CodeBuild image to STANDARD_6_0 with latest node version to use latest CDK
- Pass VPC endpoints security group to OpenSearch Serverless stack
- Update template_cdk.json
- Add monitoring
@kukushking kukushking self-assigned this Feb 3, 2023
deploy/stacks/monitoring.py Outdated Show resolved Hide resolved
deploy/stacks/monitoring.py Outdated Show resolved Hide resolved
- Make sure either OS or AOSS alarms are created
- Build hostname based on collection id to avoid CDK token manipulation
- Fix typo
deploy/stacks/backend_stack.py Show resolved Hide resolved
deploy/stacks/monitoring.py Outdated Show resolved Hide resolved
deploy/stacks/opensearch.py Outdated Show resolved Hide resolved
deploy/stacks/backend_stack.py Outdated Show resolved Hide resolved
template_cdk.json Show resolved Hide resolved
@kukushking kukushking changed the base branch from main to v1m5m0 February 9, 2023 13:16
@kukushking kukushking marked this pull request as ready for review February 9, 2023 13:16
@dlpzx dlpzx self-requested a review February 10, 2023 12:02
- Skip calling /GET info for serverless opensearch collection
- Remove unused imports
deploy/stacks/pipeline.py Show resolved Hide resolved
deploy/stacks/backend_stack.py Outdated Show resolved Hide resolved
- Remove alarm action parameter
- Fix OS/AOSS stack inputs
Copy link
Contributor

@nikpodsh nikpodsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this seems to work fine, I think we can go without it:)
Approved. Great job! 👍

@kukushking
Copy link
Contributor Author

Thanks for the review @nikpodsh!

Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging we can include what we discussed yesterday around existing customers that want to take advantage of this feature.

How do we migrate the information from OpenSearch non-serverless to serverless. At least we need to provide some info

@dlpzx
Copy link
Contributor

dlpzx commented Feb 17, 2023

Thank you for cleaning up the unnecessary packages from the CICD pipeline! The testing in v1m5m0 branch is ready, so you can go ahead and merge your changes. Great contribution @kukushking 🚀

@kukushking kukushking merged commit c4bff3e into data-dot-all:v1m5m0 Feb 17, 2023
dlpzx pushed a commit that referenced this pull request Apr 11, 2023
### Feature or Bugfix
- Feature

### Detail
- Add OpenSearch Serverless stack & corresponding feature flag
- Update client request signature ("aoss"/"es") and create service SSM
parameter
- Update domain / collection references
- Add ECS task role to OpenSearch Serverless principals
- Update CDK library to latest (2.61.1)
- Update Pipeline CodeBuild image to `AMAZON_LINUX_2_4` with latest node
version to use latest CDK and remove unnecessary packages
- Pass VPC endpoints security group to OpenSearch Serverless stack
- Update template_cdk.json
- Add monitoring

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
@dlpzx dlpzx mentioned this pull request Apr 11, 2023
dlpzx added a commit that referenced this pull request Apr 25, 2023
### Feature or Bugfix
- V1.5.0 Features. Check each PR for a complete description of the
feature.

### Detail
- #292 
- #355 
- #337 
- #427 
- #431 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Co-authored-by: kukushking <kukushkin.anton@gmail.com>
Co-authored-by: Dariusz Osiennik <osiend@amazon.com>
Co-authored-by: Noah Paige <69586985+noah-paige@users.noreply.github.com>
Co-authored-by: Dennis Goldner <107395339+degoldner@users.noreply.github.com>
dlpzx pushed a commit that referenced this pull request Apr 25, 2023
### Feature or Bugfix
- Documentation

### Relates
- #292 
- #372 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants