Configurable restricted VPC for tooling account #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…names. First draft of custom NACL
dlpzx
changed the title
|
Hi @kukushking, I tested the above configuration in a fresh deployment and it completed successfully :) |
kukushking
reviewed
Mar 3, 2023
deploy/stacks/vpc.py
Outdated
| ) | ||
| nacl.add_entry( | ||
| "entryInboundAllInVPC", | ||
| cidr=ec2.AclCidr.ipv4("10.0.0.0/16"), |
There was a problem hiding this comment.
How about referring toself.vpc.cidr here just in case the user changes the cidr from the default?
There was a problem hiding this comment.
Good idea! I just added it and I am testing it right now
dlpzx
added a commit
that referenced
this pull request
Apr 11, 2023
### Feature or Bugfix - Feature ### Detail - New cdk.json configuration parameter `tooling_vpc_restricted_nacl` - If set to `true` we create a custom NACL for the tooling data.all created VPC with the following inbound rules. Outbound allows all traffic.  - We have enabled DNS private names for CodeArtifact endpoints, to correctly resolve them inside the VPC and keep traffic within the VPC. - Modified some CodeBuild steps to install pip and npm packages from CodeArtifact instead of from the internet. - In #323, CodeBuild Linux images were updated, eliminating the need to install yum packages and node. ### Relates - #307 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Merged
dlpzx
added a commit
that referenced
this pull request
Apr 25, 2023
### Feature or Bugfix - V1.5.0 Features. Check each PR for a complete description of the feature. ### Detail - #292 - #355 - #337 - #427 - #431 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: kukushking <kukushkin.anton@gmail.com> Co-authored-by: Dariusz Osiennik <osiend@amazon.com> Co-authored-by: Noah Paige <69586985+noah-paige@users.noreply.github.com> Co-authored-by: Dennis Goldner <107395339+degoldner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
tooling_vpc_restricted_nacltruewe create a custom NACL for the tooling data.all created VPC with the following inbound rules. Outbound allows all traffic.Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.