Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Better handling of missing default VPCs #427

Merged
merged 2 commits into from
Apr 20, 2023
Merged

feat: Better handling of missing default VPCs #427

merged 2 commits into from
Apr 20, 2023

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Apr 20, 2023

Feature or Bugfix

  • Enhancement

Detail

  • Added method to check if default VPC exists instead of relying in CFN stack failing. Since it uses the cdk-look-up role we do not need to add any ec2 permissions on the pivotRole

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx requested a review from nikpodsh April 20, 2023 13:16
@dlpzx dlpzx merged commit 8052d6f into v1m5m0 Apr 20, 2023
@dlpzx dlpzx deleted the fixes-v1m5m0 branch April 21, 2023 07:19
@dlpzx dlpzx mentioned this pull request Apr 23, 2023
dlpzx added a commit that referenced this pull request Apr 25, 2023
### Feature or Bugfix
- V1.5.0 Features. Check each PR for a complete description of the
feature.

### Detail
- #292 
- #355 
- #337 
- #427 
- #431 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Co-authored-by: kukushking <kukushkin.anton@gmail.com>
Co-authored-by: Dariusz Osiennik <osiend@amazon.com>
Co-authored-by: Noah Paige <69586985+noah-paige@users.noreply.github.com>
Co-authored-by: Dennis Goldner <107395339+degoldner@users.noreply.github.com>
@dlpzx dlpzx changed the title Better handling of missing default VPCs feat: Better handling of missing default VPCs May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants