Core modularization #592
Merged
Core modularization #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-dot-all#456) Bumps pymdown-extensions from 8.1.1 to 10.0.
…l#460) ### Feature or Bugfix - Bugfix ### Detail - Solve vulnerabilities found in starlette 0.25.0 ### Relates By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
# Conflicts: # backend/dataall/db/permissions.py # backend/dataall/modules/datasets/db/dataset_repository.py
### Feature or Bugfix - BugFix ### Detail - In line (https://github.com/awslabs/aws-dataall/blob/13a2fc082694600a0dacaa7e88d0d61ec950d753/deploy/configs/cognito_urls_config.py#L61) It checks for example.com where instead the right callback to check is ```https://example.com``` and that's why it doesn't get replaced during the configuration phase. ### Relates - data-dot-all#454 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
…ew_permission_checker # Conflicts: # backend/dataall/api/Objects/Environment/resolvers.py # backend/dataall/db/api/environment.py # backend/dataall/db/api/redshift_cluster.py
…permission_checker
# Conflicts: # backend/dataall/base/db/connection.py # backend/dataall/base/utils/decorator_util.py # backend/dataall/core/environment/api/resolvers.py # backend/dataall/core/environment/services/environment_service.py # backend/dataall/core/permissions/permission_checker.py # backend/dataall/modules/dataset_sharing/services/share_managers/lf_share_manager.py # backend/dataall/modules/datasets/api/dataset/resolvers.py # backend/dataall/modules/datasets/api/storage_location/resolvers.py
…-modularization # Conflicts: # backend/dataall/api/Objects/KeyValueTag/resolvers.py # backend/dataall/api/Objects/Vote/resolvers.py # backend/dataall/api/Objects/Vpc/resolvers.py # backend/dataall/core/catalog/api/resolvers.py # backend/dataall/core/catalog/db/glossary.py # backend/dataall/core/environment/api/resolvers.py # backend/dataall/core/environment/cdk/environment_stack.py # backend/dataall/core/environment/services/environment_service.py # backend/dataall/core/organizations/db/organization.py # backend/dataall/core/stacks/db/keyvaluetag.py # backend/dataall/core/stacks/db/stack.py # backend/dataall/core/vote/db/vote.py # backend/dataall/core/vpc/db/vpc.py # backend/dataall/db/api/__init__.py # backend/dataall/modules/dashboards/indexers/dashboard_indexer.py
dbalintx
reviewed
Jul 21, 2023
dbalintx
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modularization of the core part.
It contains modularization of the core feature adn moving the rest in base.
A core feature is the feature we expect to operate in data.all constantly (no way to turn them off)
Base is some code that can't be extrated as a feature. Most likely, it's functional code like establishing database connection, opersearch indexing etc.
The core features:
This PR is mostly about restructuring.