This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Remove dead codes in TypeCast and related test codes #144
+0
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 90.13% (diff: 100%)@@ master #144 diff @@
==========================================
Files 14 14
Lines 663 649 -14
Methods 605 592 -13
Messages 0 0
Branches 58 57 -1
==========================================
- Hits 598 585 -13
+ Misses 65 64 -1
Partials 0 0
|
Member
Author
|
I am going to merge this. |
| case _: DecimalType => new BigDecimal(datum.replaceAll(",", "")) | ||
| // TODO(hossein): would be good to support other common timestamp formats | ||
| case _: TimestampType => Timestamp.valueOf(datum) | ||
| // TODO(hossein): would be good to support other common date formats |
HyukjinKwon
added a commit
that referenced
this pull request
Sep 10, 2016
This PR prepares the release for 0.3.4. This will include the changes below: - Produces correct order of columns for nested rows when user specifies a schema 527b976 - No value in nested struct causes arrayIndexOutOfBounds (19eb277) - `compression` aslias for `codec` option #145 - Remove dead codes, #144 - Fix nested element with name of parent bug, #161 - Minor documentation changes - #159 and #143 - Ignore comments even when it is surrounded white spaces #166 Author: hyukjinkwon <gurwls223@gmail.com> Closes #146 from HyukjinKwon/version-0.3.4.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
TypeCastis not used anymore. This PR removes the dead codes and related tests inTypeCastSuite.