This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Add missed other default case when parsing/inferring XML documents #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2016
Current coverage is 90.42% (diff: 100%)@@ master #166 diff @@
==========================================
Files 14 14
Lines 677 679 +2
Methods 614 619 +5
Messages 0 0
Branches 63 60 -3
==========================================
+ Hits 612 614 +2
Misses 65 65
Partials 0 0
|
Member
Author
|
I am going to merge this. |
HyukjinKwon
added a commit
that referenced
this pull request
Sep 10, 2016
This PR prepares the release for 0.3.4. This will include the changes below: - Produces correct order of columns for nested rows when user specifies a schema 527b976 - No value in nested struct causes arrayIndexOutOfBounds (19eb277) - `compression` aslias for `codec` option #145 - Remove dead codes, #144 - Fix nested element with name of parent bug, #161 - Minor documentation changes - #159 and #143 - Ignore comments even when it is surrounded white spaces #166 Author: hyukjinkwon <gurwls223@gmail.com> Closes #146 from HyukjinKwon/version-0.3.4.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for skipping multiple white spaces around a comment.
This should have been added but missed. As
XMLStreamConstants.COMMENTis always skipped here and here but it seems it is possible to have theCOMMENTis between white spaces.In this case,
factory.setProperty(XMLInputFactory.IS_COALESCING, true)does not coalesce both white spaces.In more details,
in this case,
<!--comment -->is surrounded with whitespaces.This produces the events as blow:
Current codes always filter
XmlEvent.COMMENTso it ends up withwhich does not happen in normal cases because we are coalescing multiple
XMLStreamConstants.CHARACTERSinto single one as below: