Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow to use GCP SA in databricks_credential (storage only) #4302

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Dec 7, 2024

Changes

Right now, it's only possible to use it only with purpose = "STORAGE".

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott temporarily deployed to test-trigger-is December 7, 2024 08:15 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is December 7, 2024 08:16 — with GitHub Actions Inactive
@alexott alexott force-pushed the feature/gcp-sa-support-in-credential branch from c5fbe75 to 5a60e20 Compare December 10, 2024 11:18
@alexott alexott marked this pull request as ready for review December 10, 2024 11:18
@alexott alexott requested review from a team as code owners December 10, 2024 11:18
@alexott alexott requested review from mgyucht and removed request for a team December 10, 2024 11:18
docs/resources/credential.md Outdated Show resolved Hide resolved
docs/resources/credential.md Outdated Show resolved Hide resolved
@alexott alexott force-pushed the feature/gcp-sa-support-in-credential branch from 5a60e20 to 9fd889b Compare December 12, 2024 14:50
@alexott alexott enabled auto-merge December 12, 2024 14:51
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4302
  • Commit SHA: 697cf3a21490862503c30c2bb96bbd7c1bb9963b

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12298999526

@alexott alexott disabled auto-merge December 12, 2024 15:37
@alexott alexott added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 3077b79 Dec 13, 2024
12 checks passed
@alexott alexott deleted the feature/gcp-sa-support-in-credential branch December 13, 2024 06:13
hectorcast-db added a commit that referenced this pull request Dec 18, 2024
### New Features and Improvements

 * Allow to use GCP SA in `databricks_credential` (storage only) ([#4302](#4302)).

### Bug Fixes

 * Bump Golang x/crypto to 0.31 ([#4319](#4319)).

### Internal Changes

 * Generate models with correctly computed annotations ([#4316](#4316)).
 * Update Go SDK to 0.54.0 ([#4328](#4328)).

### Dependency Updates

 * Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.15.0 to 0.16.0 ([#4320](#4320)).

### Exporter

 * Correctly handle DB-managed UC objects ([#4323](#4323)).
 * Emit WSFS/UC files from `parameters` in the jobs ([#4318](#4318)).
 * Improve support of `databricks_model_serving` ([#4324](#4324)).
 * add support for `databricks_credential` ([#4292](#4292)).
 * export `databricks_repo` for Git Folders outside of `/Repos` ([#4308](#4308)).
hectorcast-db added a commit that referenced this pull request Dec 18, 2024
 * Allow to use GCP SA in `databricks_credential` (storage only) ([#4302](#4302)).

 * Bump Golang x/crypto to 0.31 ([#4319](#4319)).

 * Generate models with correctly computed annotations ([#4316](#4316)).
 * Update Go SDK to 0.54.0 ([#4328](#4328)).

 * Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.15.0 to 0.16.0 ([#4320](#4320)).

 * Correctly handle DB-managed UC objects ([#4323](#4323)).
 * Emit WSFS/UC files from `parameters` in the jobs ([#4318](#4318)).
 * Improve support of `databricks_model_serving` ([#4324](#4324)).
 * add support for `databricks_credential` ([#4292](#4292)).
 * export `databricks_repo` for Git Folders outside of `/Repos` ([#4308](#4308)).
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2024
### New Features and Improvements

* Allow to use GCP SA in `databricks_credential` (storage only)
([#4302](#4302)).
 * Support for databricks_credential in databricks_workspace_binding


### Bug Fixes

* Bump Golang x/crypto to 0.31
([#4319](#4319)).


### Internal Changes

* Generate models with correctly computed annotations
([#4316](#4316)).
* Update Go SDK to 0.54.0
([#4328](#4328)).


### Dependency Updates

* Bump github.com/hashicorp/terraform-plugin-framework-validators from
0.15.0 to 0.16.0
([#4320](#4320)).


### Exporter

* Correctly handle DB-managed UC objects
([#4323](#4323)).
* Emit WSFS/UC files from `parameters` in the jobs
([#4318](#4318)).
* Improve support of `databricks_model_serving`
([#4324](#4324)).
* add support for `databricks_credential`
([#4292](#4292)).
* export `databricks_repo` for Git Folders outside of `/Repos`
([#4308](#4308)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants