[Internal] Generate models with correctly computed annotations #4316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
force-pushed
the
deco-24178-correct-tfsdk-computed-annotations
branch
from
f266d69 to
f937d0b
Compare
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
force-pushed
the
deco-24178-correct-tfsdk-computed-annotations
branch
from
f937d0b to
86e7b5a
Compare
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
force-pushed
the
deco-24178-correct-tfsdk-computed-annotations
branch
from
86e7b5a to
142688e
Compare
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
force-pushed
the
deco-24178-correct-tfsdk-computed-annotations
branch
from
6fc5a49 to
4255937
Compare
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Test Details: go/deco-tests/12314865729 |
mgyucht
approved these changes
Dec 13, 2024
| // The deployment artifacts for an app. | ||
| DeploymentArtifacts types.Object `tfsdk:"deployment_artifacts" tf:"optional,object"` | ||
| DeploymentArtifacts types.Object `tfsdk:"deployment_artifacts" tf:"computed,object"` |
There was a problem hiding this comment.
This was optional before but now is computed non-optional. Is that expected?
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
rauchy
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
added a commit
that referenced
this pull request
Dec 18, 2024
### New Features and Improvements * Allow to use GCP SA in `databricks_credential` (storage only) ([#4302](#4302)). ### Bug Fixes * Bump Golang x/crypto to 0.31 ([#4319](#4319)). ### Internal Changes * Generate models with correctly computed annotations ([#4316](#4316)). * Update Go SDK to 0.54.0 ([#4328](#4328)). ### Dependency Updates * Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.15.0 to 0.16.0 ([#4320](#4320)). ### Exporter * Correctly handle DB-managed UC objects ([#4323](#4323)). * Emit WSFS/UC files from `parameters` in the jobs ([#4318](#4318)). * Improve support of `databricks_model_serving` ([#4324](#4324)). * add support for `databricks_credential` ([#4292](#4292)). * export `databricks_repo` for Git Folders outside of `/Repos` ([#4308](#4308)).
hectorcast-db
added a commit
that referenced
this pull request
Dec 18, 2024
* Allow to use GCP SA in `databricks_credential` (storage only) ([#4302](#4302)). * Bump Golang x/crypto to 0.31 ([#4319](#4319)). * Generate models with correctly computed annotations ([#4316](#4316)). * Update Go SDK to 0.54.0 ([#4328](#4328)). * Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.15.0 to 0.16.0 ([#4320](#4320)). * Correctly handle DB-managed UC objects ([#4323](#4323)). * Emit WSFS/UC files from `parameters` in the jobs ([#4318](#4318)). * Improve support of `databricks_model_serving` ([#4324](#4324)). * add support for `databricks_credential` ([#4292](#4292)). * export `databricks_repo` for Git Folders outside of `/Repos` ([#4308](#4308)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
### New Features and Improvements * Allow to use GCP SA in `databricks_credential` (storage only) ([#4302](#4302)). * Support for databricks_credential in databricks_workspace_binding ### Bug Fixes * Bump Golang x/crypto to 0.31 ([#4319](#4319)). ### Internal Changes * Generate models with correctly computed annotations ([#4316](#4316)). * Update Go SDK to 0.54.0 ([#4328](#4328)). ### Dependency Updates * Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.15.0 to 0.16.0 ([#4320](#4320)). ### Exporter * Correctly handle DB-managed UC objects ([#4323](#4323)). * Emit WSFS/UC files from `parameters` in the jobs ([#4318](#4318)). * Improve support of `databricks_model_serving` ([#4324](#4324)). * add support for `databricks_credential` ([#4292](#4292)). * export `databricks_repo` for Git Folders outside of `/Repos` ([#4308](#4308)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In this PR, we've tackled an issue with our plugin framework models. Previously, fields that were meant to be computed were mistakenly generated with "computed,optional" annotations instead of just "computed."
Also, if any fields were indicated as having effective values, the effective fields also ended up with the wrong "computed,optional" tag rather than the correct "computed." We've regenerated the models to correct these annotations.
Tests
make testrun locallydocs/folderinternal/acceptance