[Exporter] Correctly handle DB-managed UC objects #4323
Merged
+47
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
requested review from
mgyucht and
tanmay-db
and removed request for
a team
mgyucht
approved these changes
Dec 16, 2024
Databricks has started to introduce UC objects that are created and managed by Databricks, i.e., storage credentials and external locations, so we can't create resources to manage them. This PR converts such managed UC objects into data sources, so we can attach permissions to them, and handle references. Other changes include: - refactoring of creation of new resource data objects - fixing a problem with codegen of data sources, so we don't need a dedicated `Body` implementation.
alexott
force-pushed
the
exporter/handle-db-managed-objects
branch
from
1a6cbea to
d213cbb
Compare
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Test Details: go/deco-tests/12359141713 |
hectorcast-db
added a commit
that referenced
this pull request
Dec 18, 2024
### New Features and Improvements * Allow to use GCP SA in `databricks_credential` (storage only) ([#4302](#4302)). ### Bug Fixes * Bump Golang x/crypto to 0.31 ([#4319](#4319)). ### Internal Changes * Generate models with correctly computed annotations ([#4316](#4316)). * Update Go SDK to 0.54.0 ([#4328](#4328)). ### Dependency Updates * Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.15.0 to 0.16.0 ([#4320](#4320)). ### Exporter * Correctly handle DB-managed UC objects ([#4323](#4323)). * Emit WSFS/UC files from `parameters` in the jobs ([#4318](#4318)). * Improve support of `databricks_model_serving` ([#4324](#4324)). * add support for `databricks_credential` ([#4292](#4292)). * export `databricks_repo` for Git Folders outside of `/Repos` ([#4308](#4308)).
hectorcast-db
added a commit
that referenced
this pull request
Dec 18, 2024
* Allow to use GCP SA in `databricks_credential` (storage only) ([#4302](#4302)). * Bump Golang x/crypto to 0.31 ([#4319](#4319)). * Generate models with correctly computed annotations ([#4316](#4316)). * Update Go SDK to 0.54.0 ([#4328](#4328)). * Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.15.0 to 0.16.0 ([#4320](#4320)). * Correctly handle DB-managed UC objects ([#4323](#4323)). * Emit WSFS/UC files from `parameters` in the jobs ([#4318](#4318)). * Improve support of `databricks_model_serving` ([#4324](#4324)). * add support for `databricks_credential` ([#4292](#4292)). * export `databricks_repo` for Git Folders outside of `/Repos` ([#4308](#4308)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
### New Features and Improvements * Allow to use GCP SA in `databricks_credential` (storage only) ([#4302](#4302)). * Support for databricks_credential in databricks_workspace_binding ### Bug Fixes * Bump Golang x/crypto to 0.31 ([#4319](#4319)). ### Internal Changes * Generate models with correctly computed annotations ([#4316](#4316)). * Update Go SDK to 0.54.0 ([#4328](#4328)). ### Dependency Updates * Bump github.com/hashicorp/terraform-plugin-framework-validators from 0.15.0 to 0.16.0 ([#4320](#4320)). ### Exporter * Correctly handle DB-managed UC objects ([#4323](#4323)). * Emit WSFS/UC files from `parameters` in the jobs ([#4318](#4318)). * Improve support of `databricks_model_serving` ([#4324](#4324)). * add support for `databricks_credential` ([#4292](#4292)). * export `databricks_repo` for Git Folders outside of `/Repos` ([#4308](#4308)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Databricks has started to introduce UC objects that are created and managed by Databricks, i.e., storage credentials and external locations, so we can't create resources to manage them.
This PR converts such managed UC objects into data sources so we can attach permissions to them and handle references. The change of ownership is still not implemented - filed #4321 to handle it.
Other changes include:
Bodyimplementation.Tests
make testrun locallydocs/folderinternal/acceptance