You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #92, the signature of idata was changed from idata(values) to idata(values, index_len), with no default handling for the latter argument. This means that all current uses of idata(values) are now broken on upgrade to 1.4.3, and there's no compatible calling method for versions 1.4.2 and 1.4.3.
I'm not too familiar with your internals, but glancing through PR #92, it looks like it could be handled safely without affecting that PR by changing the signature to something like:
defidata(values, index_len=None):
ifindex_lenisNone:
# Avoid accidentally consuming a one-time-use iterable.values=tuple(values)
index_len=len(str(len(values)))
# ... continue as normal ...
If so, I'd be happy to make the PR.
The text was updated successfully, but these errors were encountered:
The ddt package changed the function signature in version 1.4.3 from
idata(iterable) to idata(iterable, index_len). Hopefully this was just a
mistake and the new argument will be optional in future versions (see
issue datadriventests/ddt#97)
In #92, the signature of
idata
was changed fromidata(values)
toidata(values, index_len)
, with no default handling for the latter argument. This means that all current uses ofidata(values)
are now broken on upgrade to 1.4.3, and there's no compatible calling method for versions 1.4.2 and 1.4.3.I'm not too familiar with your internals, but glancing through PR #92, it looks like it could be handled safely without affecting that PR by changing the signature to something like:
If so, I'd be happy to make the PR.
The text was updated successfully, but these errors were encountered: