Zero padding fix #92
Merged
Zero padding fix #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wswld, @dirkmueller, @dtantsur, @ppentchev: It looks to me that this PR is fixing the problem mentioned in the issue #75. Is this fine or do you prefer some different way how to fix it? |
wswld
approved these changes
Sep 27, 2021
|
Hey @ntippman @martin-majlis thanks for the contribution and sorry for the wait. I should have looked into this earlier. The issue seems to be fixed now. |
This was referenced Sep 27, 2021
jakelishman
added a commit
to jakelishman/ddt
that referenced
this pull request
Sep 27, 2021
PR datadriventests#92 added an extra argument to the `idata` decorator. This had no default value, and so the calling convention was incompatible with older releases of `ddt`. This makes the second argument optional, with the previous default value inferred if it is not supplied. This means that the single-argument form of `idata` will still work, while supporting the newer method allowing it to be overridden.
jakelishman
added a commit
to jakelishman/ddt
that referenced
this pull request
Sep 27, 2021
PR datadriventests#92 added an extra argument to the `idata` decorator. The new `index_len` argument had no default value, and so the calling convention was incompatible with older releases of `ddt`. This commit makes the second argument optional, with the previous default value inferred if it is not supplied. The single-argument form of `idata` will now work again, while the newer method allowing it to be overridden is still supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #75