Make index_len argument to idata optional
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR datadriventests#92 added an extra argument to the `idata` decorator. The new `index_len` argument had no default value, and so the calling convention was incompatible with older releases of `ddt`. This commit makes the second argument optional, with the previous default value inferred if it is not supplied. The single-argument form of `idata` will now work again, while the newer method allowing it to be overridden is still supported.
jakelishman
force-pushed
the
add-default-value-idata
branch
from
5ebc47e
to
ea4f205
Compare
|
@txels, @wswld: apologies for the pings. Please could somebody have a look at this? It's currently not possible to use |
wswld
approved these changes
Oct 4, 2021
| @@ -90,20 +90,30 @@ def data(*values): | |||
| Should be added to methods of instances of ``unittest.TestCase``. | |||
|
|
|||
| """ | |||
| return idata(values, len(str(len(values)))) | |||
There was a problem hiding this comment.
Not sure how I missed this one before, thanks for taking care of this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #92 added an extra argument to the
idatadecorator. The newindex_lenargument had no default value, and so the calling conventionwas incompatible with older releases of
ddt. This commit makes thesecond argument optional, with the previous default value inferred if it
is not supplied. The single-argument form of
idatawill now workagain, while the newer method allowing it to be overridden is still
supported.
Fix #97.