Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-string cleanup #6068 #6082

Merged
merged 4 commits into from
Oct 17, 2022
Merged

f-string cleanup #6068 #6082

merged 4 commits into from
Oct 17, 2022

Conversation

eve-johns
Copy link
Contributor

@eve-johns eve-johns commented Oct 17, 2022

resolves the f-string part of #6068

Description

Cleaned up multiline f string formatting issue.

Checklist

@eve-johns eve-johns requested a review from a team October 17, 2022 19:31
@eve-johns eve-johns requested review from a team as code owners October 17, 2022 19:31
@eve-johns eve-johns requested review from iknox-fa and gshank October 17, 2022 19:31
@emmyoop emmyoop added the Hackathon Coalesce Hackathon Submissions label Oct 17, 2022
@emmyoop emmyoop requested review from emmyoop and removed request for a team, gshank and iknox-fa October 17, 2022 19:35
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small space to remove and then it looks good once you add the changelog and run pre-commit! Thanks for participating in the Hackathon at Coalesce!

)

if package is not None and not isinstance(package, str):
raise CompilationException(
f"The package argument to ref() must be a string or None, got " f"{type(package)}"
f"The package argument to ref() must be a string or None, got {type(package)}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has two spaces instead of one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing it out!

@cla-bot cla-bot bot added the cla:yes label Oct 17, 2022
@emmyoop
Copy link
Member

emmyoop commented Oct 17, 2022

You'll want to run pre-commit (docs) and also create a Changelog entry (Under the Hood).

@emmyoop emmyoop self-requested a review October 17, 2022 20:41
@leahwicz leahwicz merged commit a9c8bc0 into dbt-labs:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Hackathon Coalesce Hackathon Submissions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants