Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated string formatting on non-f-strings. #6086

Merged

Conversation

luke-bassett
Copy link
Contributor

resolves

This resolves the non-f-string portion of this issue #6068. The rest was covered by this PR #6082.

Description

Found all cases of strings separated by white space on a single line and
removed white space separation. EX: "hello " "world" -> "hello world".

Checklist

Found all cases of strings separated by white space on a single line and
removed white space separation. EX: "hello " "world" -> "hello world".
@luke-bassett luke-bassett requested a review from a team as a code owner October 17, 2022 20:15
@luke-bassett luke-bassett requested a review from a team October 17, 2022 20:15
@luke-bassett luke-bassett requested review from a team as code owners October 17, 2022 20:15
@cla-bot cla-bot bot added the cla:yes label Oct 17, 2022
@luke-bassett
Copy link
Contributor Author

Completed changie entry

@leahwicz leahwicz added the Hackathon Coalesce Hackathon Submissions label Oct 17, 2022
@luke-bassett
Copy link
Contributor Author

I have run this code in development and it appears to resolve the stated issue

I think I did this by running make test and black. If more is required let me know.

@eve-johns
Copy link
Contributor

Yay!

@emmyoop emmyoop removed request for a team, ChenyuLInx and VersusFacit October 17, 2022 20:19
@emmyoop
Copy link
Member

emmyoop commented Oct 17, 2022

@luke-bassett it looks like your changelog did not make it into the fork. You'll need to get that added before I can approve this.

@luke-bassett
Copy link
Contributor Author

luke-bassett commented Oct 17, 2022

@emmyoop Oops, didn't realize I needed to commit it to the repo. Now it's there I think.

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for you contribution @luke-bassett and participating in the Hackathon!

@emmyoop emmyoop merged commit 35f7975 into dbt-labs:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Hackathon Coalesce Hackathon Submissions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants