Refactor/bgp peer #180
Merged
Refactor/bgp peer #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| TTL string `mikrotik:"ttl"` | ||
| UpdateSource string `mikrotik:"update-source"` | ||
| UseBfd bool `mikrotik:"use-bfd"` | ||
| Id string `mikrotik:".id" codegen:"id,mikrotikID"` |
There was a problem hiding this comment.
this change also breaks the client module
| @@ -61,7 +61,11 @@ func GenericReadResource(terraformModel interface{}, mikrotikModel client.Resour | |||
| return | |||
| } | |||
|
|
|||
| resource, err := client.Find(mikrotikModel) | |||
| resource, err := mikrotikClient.Find(mikrotikModel) | |||
| if client.IsNotFoundError(err) { | |||
There was a problem hiding this comment.
this check was missing, so it was a bug.
I didn't create a separate pair of issue/PR for it, but let me know if you want it to be split for better visibility.
There was a problem hiding this comment.
I think it's ok to fix it inline here.
15 tasks
17 tasks
ddelnano
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.