-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/bgp peer #180
Merged
Merged
Refactor/bgp peer #180
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,135 +1,112 @@ | ||
| package client | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "log" | ||
| "github.com/go-routeros/routeros" | ||
| ) | ||
|
|
||
| // BgpPeer Mikrotik resource | ||
| type BgpPeer struct { | ||
| ID string `mikrotik:".id"` | ||
| Name string `mikrotik:"name"` | ||
| AddressFamilies string `mikrotik:"address-families"` | ||
| AllowAsIn int `mikrotik:"allow-as-in"` | ||
| AsOverride bool `mikrotik:"as-override"` | ||
| CiscoVplsNlriLenFmt string `mikrotik:"cisco-vpls-nlri-len-fmt"` | ||
| Comment string `mikrotik:"comment"` | ||
| DefaultOriginate string `mikrotik:"default-originate"` | ||
| Disabled bool `mikrotik:"disabled"` | ||
| HoldTime string `mikrotik:"hold-time"` | ||
| InFilter string `mikrotik:"in-filter"` | ||
| Instance string `mikrotik:"instance"` | ||
| KeepAliveTime string `mikrotik:"keepalive-time"` | ||
| MaxPrefixLimit int `mikrotik:"max-prefix-limit"` | ||
| MaxPrefixRestartTime string `mikrotik:"max-prefix-restart-time"` | ||
| Multihop bool `mikrotik:"multihop"` | ||
| NexthopChoice string `mikrotik:"nexthop-choice"` | ||
| OutFilter string `mikrotik:"out-filter"` | ||
| Passive bool `mikrotik:"passive"` | ||
| RemoteAddress string `mikrotik:"remote-address"` | ||
| RemoteAs int `mikrotik:"remote-as"` | ||
| RemotePort int `mikrotik:"remote-port"` | ||
| RemovePrivateAs bool `mikrotik:"remove-private-as"` | ||
| RouteReflect bool `mikrotik:"route-reflect"` | ||
| TCPMd5Key string `mikrotik:"tcp-md5-key"` | ||
| TTL string `mikrotik:"ttl"` | ||
| UpdateSource string `mikrotik:"update-source"` | ||
| UseBfd bool `mikrotik:"use-bfd"` | ||
| Id string `mikrotik:".id" codegen:"id,mikrotikID"` | ||
| Name string `mikrotik:"name" codegen:"name,required,terraformID"` | ||
| AddressFamilies string `mikrotik:"address-families" codegen:"address_families,optional,computed"` | ||
| AllowAsIn int `mikrotik:"allow-as-in" codegen:"allow_as_in"` | ||
| AsOverride bool `mikrotik:"as-override" codegen:"as_override"` | ||
| CiscoVplsNlriLenFmt string `mikrotik:"cisco-vpls-nlri-len-fmt" codegen:"cisco_vpls_nlri_len_fmt"` | ||
| Comment string `mikrotik:"comment" codegen:"comment"` | ||
| DefaultOriginate string `mikrotik:"default-originate" codegen:"default_originate,optional,computed"` | ||
| Disabled bool `mikrotik:"disabled" codegen:"disabled"` | ||
| HoldTime string `mikrotik:"hold-time" codegen:"hold_time,optional,computed"` | ||
| InFilter string `mikrotik:"in-filter" codegen:"in_filter"` | ||
| Instance string `mikrotik:"instance" codegen:"instance"` | ||
| KeepAliveTime string `mikrotik:"keepalive-time" codegen:"keepalive_time"` | ||
| MaxPrefixLimit int `mikrotik:"max-prefix-limit" codegen:"max_prefix_limit"` | ||
| MaxPrefixRestartTime string `mikrotik:"max-prefix-restart-time" codegen:"max_prefix_restart_time"` | ||
| Multihop bool `mikrotik:"multihop" codegen:"multihop"` | ||
| NexthopChoice string `mikrotik:"nexthop-choice" codegen:"nexthop_choice,optional,computed"` | ||
| OutFilter string `mikrotik:"out-filter" codegen:"out_filter"` | ||
| Passive bool `mikrotik:"passive" codegen:"passive"` | ||
| RemoteAddress string `mikrotik:"remote-address" codegen:"remote_address,required"` | ||
| RemoteAs int `mikrotik:"remote-as" codegen:"remote_as,required"` | ||
| RemotePort int `mikrotik:"remote-port" codegen:"remote_port"` | ||
| RemovePrivateAs bool `mikrotik:"remove-private-as" codegen:"remove_private_as"` | ||
| RouteReflect bool `mikrotik:"route-reflect" codegen:"route_reflect"` | ||
| TCPMd5Key string `mikrotik:"tcp-md5-key" codegen:"tcp_md5_key"` | ||
| TTL string `mikrotik:"ttl" codegen:"ttl,optional,computed"` | ||
| UpdateSource string `mikrotik:"update-source" codegen:"update_source"` | ||
| UseBfd bool `mikrotik:"use-bfd" codegen:"use_bfd"` | ||
| } | ||
|
|
||
| func (client Mikrotik) AddBgpPeer(b *BgpPeer) (*BgpPeer, error) { | ||
| c, err := client.getMikrotikClient() | ||
| var _ Resource = (*BgpPeer)(nil) | ||
|
|
||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| cmd := Marshal("/routing/bgp/peer/add", b) | ||
| func (b *BgpPeer) ActionToCommand(a Action) string { | ||
| return map[Action]string{ | ||
| Add: "/routing/bgp/peer/add", | ||
| Find: "/routing/bgp/peer/print", | ||
| Update: "/routing/bgp/peer/set", | ||
| Delete: "/routing/bgp/peer/remove", | ||
| }[a] | ||
| } | ||
|
|
||
| log.Printf("[INFO] Running the mikrotik command: `%s`", cmd) | ||
| r, err := c.RunArgs(cmd) | ||
| log.Printf("[DEBUG] /routing/bgp/peer/add returned %v", r) | ||
| if err != nil { | ||
| if legacyBgpUnsupported(err) { | ||
| return nil, LegacyBgpUnsupported{} | ||
| } | ||
| return nil, err | ||
| } | ||
| func (b *BgpPeer) IDField() string { | ||
| return ".id" | ||
| } | ||
|
|
||
| return client.FindBgpPeer(b.Name) | ||
| func (b *BgpPeer) ID() string { | ||
| return b.Id | ||
| } | ||
|
|
||
| func (client Mikrotik) FindBgpPeer(name string) (*BgpPeer, error) { | ||
| c, err := client.getMikrotikClient() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| func (b *BgpPeer) SetID(id string) { | ||
| b.Id = id | ||
| } | ||
|
|
||
| cmd := []string{"/routing/bgp/peer/print", "?name=" + name} | ||
| log.Printf("[INFO] Running the mikrotik command: `%s`", cmd) | ||
| r, err := c.RunArgs(cmd) | ||
| func (b *BgpPeer) AfterAddHook(r *routeros.Reply) { | ||
| b.Id = r.Done.Map["ret"] | ||
| } | ||
|
|
||
| if err != nil { | ||
| if legacyBgpUnsupported(err) { | ||
| return nil, LegacyBgpUnsupported{} | ||
| } | ||
| return nil, err | ||
| } | ||
| func (b *BgpPeer) FindField() string { | ||
| return "name" | ||
| } | ||
|
|
||
| log.Printf("[DEBUG] Find bgp peer: `%v`", cmd) | ||
| func (b *BgpPeer) FindFieldValue() string { | ||
| return b.Name | ||
| } | ||
|
|
||
| bgpPeer := BgpPeer{} | ||
| func (b *BgpPeer) DeleteField() string { | ||
| return "numbers" | ||
| } | ||
|
|
||
| err = Unmarshal(*r, &bgpPeer) | ||
| func (b *BgpPeer) DeleteFieldValue() string { | ||
| return b.Name | ||
| } | ||
|
|
||
| // Typed wrappers | ||
| func (c Mikrotik) AddBgpPeer(r *BgpPeer) (*BgpPeer, error) { | ||
| res, err := c.Add(r) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if bgpPeer.Name == "" { | ||
| return nil, NewNotFound(fmt.Sprintf("bgp peer `%s` not found", name)) | ||
| } | ||
|
|
||
| return &bgpPeer, nil | ||
| return res.(*BgpPeer), nil | ||
| } | ||
|
|
||
| func (client Mikrotik) UpdateBgpPeer(b *BgpPeer) (*BgpPeer, error) { | ||
| c, err := client.getMikrotikClient() | ||
|
|
||
| func (c Mikrotik) UpdateBgpPeer(r *BgpPeer) (*BgpPeer, error) { | ||
| res, err := c.Update(r) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| cmd := Marshal("/routing/bgp/peer/set", b) | ||
|
|
||
| log.Printf("[INFO] Running the mikrotik command: `%s`", cmd) | ||
| _, err = c.RunArgs(cmd) | ||
| return res.(*BgpPeer), nil | ||
| } | ||
|
|
||
| func (c Mikrotik) FindBgpPeer(name string) (*BgpPeer, error) { | ||
| res, err := c.Find(&BgpPeer{Name: name}) | ||
| if err != nil { | ||
| if legacyBgpUnsupported(err) { | ||
| return nil, LegacyBgpUnsupported{} | ||
| } | ||
| return nil, err | ||
| } | ||
|
|
||
| return client.FindBgpPeer(b.Name) | ||
| return res.(*BgpPeer), nil | ||
| } | ||
|
|
||
| func (client Mikrotik) DeleteBgpPeer(name string) error { | ||
| c, err := client.getMikrotikClient() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| bgpPeer, err := client.FindBgpPeer(name) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| cmd := []string{"/routing/bgp/peer/remove", "=numbers=" + bgpPeer.Name} | ||
| log.Printf("[INFO] Running the mikrotik command: `%s`", cmd) | ||
| r, err := c.RunArgs(cmd) | ||
| log.Printf("[DEBUG] Remove bgp peer via mikrotik api: %v", r) | ||
|
|
||
| return err | ||
| func (c Mikrotik) DeleteBgpPeer(name string) error { | ||
| return c.Delete(&BgpPeer{Name: name}) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change also breaks the
clientmodule