-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit Tests Swallow TableUpdateValidator errors #1717
Comments
mofojed
pushed a commit
that referenced
this issue
Jan 17, 2024
# [0.59.0](deephaven/web-client-ui@v0.58.0...v0.59.0) (2024-01-17) ### Bug Fixes * GoToRow timestamp fails when selected row is out of view ([#1717](deephaven/web-client-ui#1717)) ([9ddc973](deephaven/web-client-ui@9ddc973)), closes [#1561](deephaven/web-client-ui#1561) * Interface for IrisGridTableModelTemplate.backgroundColorForCell ([#1699](deephaven/web-client-ui#1699)) ([73e1837](deephaven/web-client-ui@73e1837)), closes [#1697](deephaven/web-client-ui#1697) * Moved logos so they show in production build ([#1713](deephaven/web-client-ui#1713)) ([a3bea73](deephaven/web-client-ui@a3bea73)), closes [#1712](deephaven/web-client-ui#1712) * re-colorize command codeblocks when theme changes ([#1731](deephaven/web-client-ui#1731)) ([b1e42f5](deephaven/web-client-ui@b1e42f5)) * TimeInput not triggering onChange on incomplete values ([#1711](deephaven/web-client-ui#1711)) ([6894d96](deephaven/web-client-ui@6894d96)), closes [#1710](deephaven/web-client-ui#1710) ### Features * Action button tooltips ([#1706](deephaven/web-client-ui#1706)) ([bff6bf9](deephaven/web-client-ui@bff6bf9)), closes [#1705](deephaven/web-client-ui#1705) * Add support for useDeferredApi ([#1725](deephaven/web-client-ui#1725)) ([51ebe1b](deephaven/web-client-ui@51ebe1b)) * Improved preload variable handling ([#1723](deephaven/web-client-ui#1723)) ([ed41c42](deephaven/web-client-ui@ed41c42)), closes [#1695](deephaven/web-client-ui#1695) [#1679](deephaven/web-client-ui#1679) * NavTabList component ([#1698](deephaven/web-client-ui#1698)) ([96641fb](deephaven/web-client-ui@96641fb)) * Reject promise immediately if var not found ([#1718](deephaven/web-client-ui#1718)) ([43d40bd](deephaven/web-client-ui@43d40bd)), closes [#1701](deephaven/web-client-ui#1701) * theming tweaks ([#1727](deephaven/web-client-ui#1727)) ([f919a7e](deephaven/web-client-ui@f919a7e)) ### BREAKING CHANGES * - Subclasses of IrisGridTableModelTemplate or it's subclasses that use backgroundColorForCell may need to update their signature to accept the theme if they are calling the superclass Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
If you have a unit test that fails table update validation (e.g. because the engine is lying about modified state); then we have an assertion failure from the UGP that kills the test and leaves the UGP locked. There is a cleanup rule that fires:
UGP reset for unit tests reported errors:
unit test run pool thread: UGP exclusive lock is still held
UGP reset for unit tests reported errors:
unit test run pool thread: UGP exclusive lock is still held
java.lang.IllegalStateException: UGP reset for unit tests reported errors:
unit test run pool thread: UGP exclusive lock is still held
at io.deephaven.engine.updategraph.UpdateGraphProcessor.resetForUnitTests(UpdateGraphProcessor.java:810)
at io.deephaven.engine.updategraph.UpdateGraphProcessor.resetForUnitTests(UpdateGraphProcessor.java:737)
at io.deephaven.engine.table.impl.RefreshingTableTestCase.tearDown(RefreshingTableTestCase.java:76)
at io.deephaven.test.junit4.EngineCleanup.tearDown(EngineCleanup.java:22)
at io.deephaven.test.junit4.EngineCleanup$1.evaluate(EngineCleanup.java:42)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
....
Which suppresses the actual error that I would like to see from the TableUpdateValidator.
This can be extended to any error which is uncaught.
Versions
The text was updated successfully, but these errors were encountered: