Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add action for assisting with badge verification and migrate to nginx #191

Merged
merged 37 commits into from
Aug 29, 2024

Conversation

corang
Copy link
Contributor

@corang corang commented Jul 31, 2024

  • move badge logic to uds task
    • conditional logic based on github ci or not
  • change example package to nginx
    • all 3 flavors
    • behind authservice or sso?
  • extend badge logic to work for multi ns/package crd
  • Summary at end of badge script
  • More validations:
    • package version matches app version in each flavor
  • group sections for gh actions (headers?)
  • better kubectl-validate pathing for binary

.github/actions/verify-badge/action.yaml Outdated Show resolved Hide resolved
.github/actions/verify-badge/action.yaml Outdated Show resolved Hide resolved
.github/actions/verify-badge/action.yaml Outdated Show resolved Hide resolved
.github/actions/verify-badge/action.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@andrewg-xyz andrewg-xyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two overall suggestions

  1. change everything to "warning" right now. There are assumptions made that may not be accurate.
  2. shift logic to tasks.yaml - "builders" should be able to verify all of this easily prior to CI checkout.

Testing out with warnings on packages is a great start, but we should be wary of complication. Should some things shift to elsewhere in the stack? (like netpols from pepr for example or /healthz, ready endpoints)

@daveworth
Copy link
Contributor

I wanted to publicly add that I love this work @corang - it's exactly the direction and shape of work I was hoping to see in Marketplace and it happened with exactly zero nudging from me. ❤️ 🦄

@corang
Copy link
Contributor Author

corang commented Aug 1, 2024

Two overall suggestions

1. change everything to "warning" right now. There are assumptions made that may not be accurate.

2. shift logic to tasks.yaml - "builders" should be able to verify all of this easily prior to CI checkout.

Testing out with warnings on packages is a great start, but we should be wary of complication. Should some things shift to elsewhere in the stack? (like netpols from pepr for example or /healthz, ready endpoints)

  1. I left some things as warning but the action will never "fail" due to continue on error
  2. I'd like to do this eventually but while actively figuring out what logic goes in here I'm going to keep it as an action only

@andrewg-xyz
Copy link
Contributor

Two overall suggestions

1. change everything to "warning" right now. There are assumptions made that may not be accurate.

2. shift logic to tasks.yaml - "builders" should be able to verify all of this easily prior to CI checkout.

Testing out with warnings on packages is a great start, but we should be wary of complication. Should some things shift to elsewhere in the stack? (like netpols from pepr for example or /healthz, ready endpoints)

  1. I left some things as warning but the action will never "fail" due to continue on error
  2. I'd like to do this eventually but while actively figuring out what logic goes in here I'm going to keep it as an action only

@corang Isn't it easier to test as tasks you can run locally vs github actions? Copy on long-term desire. Keep in mind the in-portability aspect of doing this in github actions? What if a vendor is integrating and they dont' use github for example?

@corang corang changed the title feat: add action for assisting with badge verification feat: add action for assisting with badge verification and migrate to nginx Aug 2, 2024
@corang corang self-assigned this Aug 2, 2024
@corang corang changed the title feat: add action for assisting with badge verification and migrate to nginx feat: add action for assisting with badge verification and migrate to k8s-dashboard Aug 2, 2024
@corang corang changed the title feat: add action for assisting with badge verification and migrate to k8s-dashboard feat: add action for assisting with badge verification and migrate to nginx Aug 5, 2024
chart/values.yaml Outdated Show resolved Hide resolved
andrewg-xyz
andrewg-xyz previously approved these changes Aug 22, 2024
chart/templates/uds-package.yaml Outdated Show resolved Hide resolved
common/zarf.yaml Outdated Show resolved Hide resolved
common/zarf.yaml Show resolved Hide resolved
chart/.helmignore Outdated Show resolved Hide resolved
src/nginx/Chart.yaml Outdated Show resolved Hide resolved
src/nginx/templates/NOTES.txt Outdated Show resolved Hide resolved
tasks.yaml Outdated Show resolved Hide resolved
tasks/badge.yaml Show resolved Hide resolved
tasks/badge.yaml Show resolved Hide resolved
values/common.yaml Outdated Show resolved Hide resolved
@corang
Copy link
Contributor Author

corang commented Aug 27, 2024

Added a new issue #220

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with those two tech debt issues

@corang corang merged commit 79a5edf into main Aug 29, 2024
15 checks passed
@corang corang deleted the badge-verify-auto branch August 29, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants