fix: initial creation of child logging #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjnagel
reviewed
Jul 3, 2024
mjnagel
reviewed
Jul 8, 2024
mjnagel
reviewed
Jul 8, 2024
mjnagel
reviewed
Jul 8, 2024
|
Adding this issue as a potential follow on to work on creating more consistent structured data for our log lines so we could potentially go a step further to help users answer the question "Show me the operator logs just for my Package." and just in general keep ourselves consistent with which what kind of data we are attaching to our log lines. This data contract (the types we use) would be useful for anyone consuming our logs like UDS Engine. |
rjferguson21
reviewed
Jul 8, 2024
mjnagel
reviewed
Jul 8, 2024
mjnagel
previously approved these changes
Jul 8, 2024
mjnagel
approved these changes
Jul 8, 2024
rjferguson21
approved these changes
Jul 8, 2024
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
## Description The main goal is to be able to have pepr maintain one level of logging ( info ) and uds logs at another level ( debug ). There are some log changes in the package output to decrease extra noise, as well as a few logs moved from debug to trace level. This change also addresses a comment on another PR about JWT's being logged, which was part of pepr logs at the debug level. Definitely open to discussions about at what level we want to log the childLog subproject. ## Related Issue Fixes #526 Relates to #201 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed --------- Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
mjnagel
pushed a commit
that referenced
this pull request
Jul 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.24.0](v0.23.0...v0.24.0) (2024-07-12) ### ⚠ BREAKING CHANGES * set istio passthrough gateway as optional component (#547) ### Features * add unicorn flavor to uds-core ([#507](#507)) ([a412581](a412581)) * added standalone dns service for loki ([#548](#548)) ([e2efdf9](e2efdf9)) * enable authservice integration ([#201](#201)) ([1d4df64](1d4df64)) * set istio passthrough gateway as optional component (#547) ([e1cab61](e1cab61)) * update to using default scrapeclass for tls config ([#517](#517)) ([258bb6b](258bb6b)) ### Bug Fixes * decouple `devMode` and postgres egress ([#554](#554)) ([1a98779](1a98779)) * grafana logout not working in some environments ([#559](#559)) ([ccb9d9e](ccb9d9e)) * initial creation of child logging ([#533](#533)) ([00a5140](00a5140)) * podmonitor mTLS mutations ([#566](#566)) ([eb613e1](eb613e1)) ### Miscellaneous * add util function for purging orphans ([#565](#565)) ([e84229a](e84229a)) * allow istio proxy injection in zarf ignored namespaces (#513) ([8921b58](8921b58)) * **deps:** update githubactions upload-artifact to v4.3.4 ([#543](#543)) ([20889f2](20889f2)) * **deps:** update grafana helm chart to v8.3.2 ([#542](#542)) ([8ec260c](8ec260c)) * **deps:** update pepr dependencies (jest, uds-common) ([#537](#537)) ([547c0bf](547c0bf)) * **deps:** update promtail helm chart to v6.16.3 ([#538](#538)) ([48b3fea](48b3fea)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main goal is to be able to have pepr maintain one level of logging ( info ) and uds logs at another level ( debug ).
There are some log changes in the package output to decrease extra noise, as well as a few logs moved from debug to trace level.
This change also addresses a comment on another PR about JWT's being logged, which was part of pepr logs at the debug level.
Definitely open to discussions about at what level we want to log the childLog subproject.
Related Issue
Fixes #526
Relates to #201
Type of change
Checklist before merging