Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decouple devMode and postgres egress #554

Merged
merged 18 commits into from
Jul 12, 2024
Merged

fix: decouple devMode and postgres egress #554

merged 18 commits into from
Jul 12, 2024

Conversation

noahpb
Copy link
Contributor

@noahpb noahpb commented Jul 9, 2024

Description

Updates the internal keycloak helm chart to be more explicit about using an external postgres database connection.
Notable changes are:

  • Configures egress rule and keycloak env vars for postgres based on postgresql being populated
  • Defaults postgresql.username, postgresql.password, postgresql.database, and postgresql.host to an empty string
  • Adds option to enable debug logging via debugMode: true
  • Adds a fail case when devMode is true and postgresql has values defined
  • Adds fail cases when users do not supply required values for postgresql when devMode is false

Related Issue

Fixes #489

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@noahpb
Copy link
Contributor Author

noahpb commented Jul 9, 2024

In the codecentric helm chart for keycloak, the postgres values are used to configure the postgres dependency. I considered renaming postgres to something like database or externalPostgres to reflect that we're no longer using the postgres subchart, but opted not to as this would be a breaking change.

@noahpb noahpb marked this pull request as ready for review July 9, 2024 19:07
src/keycloak/chart/values.yaml Outdated Show resolved Hide resolved
src/keycloak/chart/values.yaml Outdated Show resolved Hide resolved
src/keycloak/chart/templates/statefulset.yaml Outdated Show resolved Hide resolved
@noahpb noahpb marked this pull request as draft July 10, 2024 12:50
src/keycloak/chart/README.md Outdated Show resolved Hide resolved
src/keycloak/chart/templates/_helpers.tpl Show resolved Hide resolved
@noahpb noahpb marked this pull request as ready for review July 11, 2024 19:04
@mjnagel mjnagel merged commit 1a98779 into main Jul 12, 2024
16 checks passed
@mjnagel mjnagel deleted the bugfix/keycloak-dev branch July 12, 2024 17:25
mjnagel pushed a commit that referenced this pull request Jul 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.24.0](v0.23.0...v0.24.0)
(2024-07-12)


### ⚠ BREAKING CHANGES

* set istio passthrough gateway as optional component
(#547)

### Features

* add unicorn flavor to uds-core
([#507](#507))
([a412581](a412581))
* added standalone dns service for loki
([#548](#548))
([e2efdf9](e2efdf9))
* enable authservice integration
([#201](#201))
([1d4df64](1d4df64))
* set istio passthrough gateway as optional component
(#547)
([e1cab61](e1cab61))
* update to using default scrapeclass for tls config
([#517](#517))
([258bb6b](258bb6b))


### Bug Fixes

* decouple `devMode` and postgres egress
([#554](#554))
([1a98779](1a98779))
* grafana logout not working in some environments
([#559](#559))
([ccb9d9e](ccb9d9e))
* initial creation of child logging
([#533](#533))
([00a5140](00a5140))
* podmonitor mTLS mutations
([#566](#566))
([eb613e1](eb613e1))


### Miscellaneous

* add util function for purging orphans
([#565](#565))
([e84229a](e84229a))
* allow istio proxy injection in zarf ignored namespaces
(#513)
([8921b58](8921b58))
* **deps:** update githubactions upload-artifact to v4.3.4
([#543](#543))
([20889f2](20889f2))
* **deps:** update grafana helm chart to v8.3.2
([#542](#542))
([8ec260c](8ec260c))
* **deps:** update pepr dependencies (jest, uds-common)
([#537](#537))
([547c0bf](547c0bf))
* **deps:** update promtail helm chart to v6.16.3
([#538](#538))
([48b3fea](48b3fea))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

egress rule for postgres should not be tied to devMode
2 participants