Tech: massive gems update, phase 1 #9967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinux
force-pushed
the
bundle-update-phase-1
branch
from
16f059c to
2fa3510
Compare
colinux
force-pushed
the
bundle-update-phase-1
branch
2 times, most recently
from
176d184 to
f7ee964
Compare
colinux
commented
Feb 7, 2024
| @@ -58,7 +58,7 @@ def index | |||
| @dossiers_traites = current_user.dossiers.state_termine.merge(@dossiers_visibles) | |||
| @dossiers_invites = current_user.dossiers_invites.merge(@dossiers_visibles) | |||
| @dossiers_supprimes_recemment = current_user.dossiers.hidden_by_user.merge(ordered_dossiers) | |||
| @dossier_transferes = @dossiers_visibles.where(dossier_transfer_id: DossierTransfer.for_email(current_user.email).ids) | |||
| @dossier_transferes = @dossiers_visibles.where(dossier_transfer_id: DossierTransfer.for_email(current_user.email)) | |||
There was a problem hiding this comment.
rubocop: permet de faire un subselect plutôt que 2 requêtes
colinux
commented
Feb 7, 2024
| @@ -1436,7 +1438,6 @@ Style/SymbolLiteral: | |||
|
|
|||
| Style/SymbolProc: | |||
| Enabled: true | |||
| IgnoredMethods: [after] | |||
There was a problem hiding this comment.
l'option n'est plus supportée depuis un moment, et on n'est plus concerné de toute façon
colinux
force-pushed
the
bundle-update-phase-1
branch
from
7a6fa76 to
c4110c3
Compare
LeSim
approved these changes
Feb 12, 2024
Merged
via the queue into
demarches-simplifiees:main
with commit Feb 12, 2024
2875991
16 checks passed
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Découpage de #9948 pour livrer en 2 ou 3 temps.
Nouvelles versions majeures (au sens semver) :
(La plupart sont des BC car elles correspondent à des arrêts du support ruby < 3 ou rails < 7)
Autre :
Suite: #9972 (update administrate)