Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for files named Containerfile rather than Dockerfile #6067

Closed
1 task done
andrewazores opened this issue Nov 7, 2022 · 6 comments · Fixed by #11141 · May be fixed by #6068
Closed
1 task done

Support for files named Containerfile rather than Dockerfile #6067

andrewazores opened this issue Nov 7, 2022 · 6 comments · Fixed by #11141 · May be fixed by #6068
Labels
L: docker Docker containers T: feature-request Requests for new features

Comments

@andrewazores
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Feature description

OCI tooling like podman and buildah supports and suggests the more neutral name Containerfile. These use the same syntax as Dockerfile. It would be nice if the docker ecosystem supported this alternate file name.

@andrewazores andrewazores added the T: feature-request Requests for new features label Nov 7, 2022
@deivid-rodriguez deivid-rodriguez added the L: docker Docker containers label Nov 8, 2022
@andrewazores
Copy link
Author

andrewazores commented Nov 8, 2022

An alternate solution would be to allow specification of the full path to the Dockerfile/Containerfile in the dependabot config yaml, rather than specifying the path to the directory that is expected to contain a file named Dockerfile. But this seems like a much broader config change that would impact every ecosystem. Testing for either Dockerfile or Containerfile fits in a narrower scope of just the docker ecosystem and should be backward-compatible.

Though, it still won't fully work for projects that may have multiple different Dockerfiles/Containerfiles for different build profiles. Quarkus, for example, normally has a Dockerfile.jvm and a Dockerfile.native , depending on whether the build produced JVM bytecode or a native image.

@dhirschfeld
Copy link

An alternate solution would be to allow specification of the full path to the Dockerfile/Containerfile in the dependabot config yaml, rather than specifying the path to the directory that is expected to contain a file named Dockerfile.

+:100: not even docker requires you to name your file Dockerfile - you can call it whatever you want and point buildx to it with --file.

https://docs.docker.com/engine/reference/commandline/build/#specify-a-dockerfile--f

@ssbarnea
Copy link

Ideally we should expose the filename pattern, so people can edit it. Use of Containerfile instead of Dockerfile is very popular and gaining traction as it is brand-agnostic.

@cidrblock
Copy link

cidrblock commented Dec 15, 2022

+1 for using alternate names other than .*dockerfile.*. I like the idea of using an option user-provided regex.

Jorann added a commit to infonl/dimpact-zaakafhandelcomponent that referenced this issue Jan 17, 2024
Let dependabot check for docker dependency updates.

This will rename the `Containerfile` to `Dockerfile`, otherwise it won't
work, see: dependabot/dependabot-core#6067

---------

Co-authored-by: Bas de Wit <bas@info.nl>
ssbarnea added a commit to ansible/ansible-language-server that referenced this issue Jan 21, 2024
ssbarnea added a commit to ansible/ansible-language-server that referenced this issue Jan 21, 2024
ssbarnea added a commit to ansible/ansible-language-server that referenced this issue Jan 21, 2024
* Improve test-setup.sh for macos

- discover broken virtualens (after python upgrade)
- implement workaround for building ansible-pylibssh

Related: ansible/pylibssh#207

* Make dockerfile dependabot compatible

See dependabot/dependabot-core#6067
eskultety added a commit to eskultety/cachi2 that referenced this issue Jun 24, 2024
Previous commit pinned the RockyLinux base image to the latest (at the
time of writing) digest. By pinning base images to particular digests
we can use dependabot to update the digests whenever a new base image
build is available.
Unfortunately, dependabot (at the time of writing) doesn't support
monitoring of a container instructions document which isn't named
"Dockerfile", i.e. the more universal "Containerfile" name isn't
supported yet [1]. Therefore, this patch also renames Containerfile to
Dockerfile in order to enable dependabot monitoring of this file within
github actions.

To keep this change from affecting any existing build recipes pointing
to a particular file explicitly a "Containerfile" symlink is created as
well.

[1] dependabot/dependabot-core#6067

Signed-off-by: Erik Skultety <eskultet@redhat.com>
eskultety added a commit to eskultety/cachi2 that referenced this issue Jun 26, 2024
Previous commit pinned the RockyLinux base image to the latest (at the
time of writing) digest. By pinning base images to particular digests
we can use dependabot to update the digests whenever a new base image
build is available.
Unfortunately, dependabot (at the time of writing) doesn't support
monitoring of a container instructions document which isn't named
"Dockerfile", i.e. the more universal "Containerfile" name isn't
supported yet [1]. Therefore, this patch also renames Containerfile to
Dockerfile in order to enable dependabot monitoring of this file within
github actions.

To keep this change from affecting any existing build recipes pointing
to a particular file explicitly a "Containerfile" symlink is created as
well.

[1] dependabot/dependabot-core#6067

Signed-off-by: Erik Skultety <eskultet@redhat.com>
github-merge-queue bot pushed a commit to containerbuildsystem/cachi2 that referenced this issue Jun 26, 2024
Previous commit pinned the RockyLinux base image to the latest (at the
time of writing) digest. By pinning base images to particular digests
we can use dependabot to update the digests whenever a new base image
build is available.
Unfortunately, dependabot (at the time of writing) doesn't support
monitoring of a container instructions document which isn't named
"Dockerfile", i.e. the more universal "Containerfile" name isn't
supported yet [1]. Therefore, this patch also renames Containerfile to
Dockerfile in order to enable dependabot monitoring of this file within
github actions.

To keep this change from affecting any existing build recipes pointing
to a particular file explicitly a "Containerfile" symlink is created as
well.

[1] dependabot/dependabot-core#6067

Signed-off-by: Erik Skultety <eskultet@redhat.com>
Copy link
Contributor

👋 This issue has been marked as stale because it has been open for 2 years with no activity. You can comment on the issue to hold stalebot off for a while, or do nothing. If you do nothing, this issue will be closed eventually by the stalebot. Please see CONTRIBUTING.md for more policy details.

@github-actions github-actions bot added the Stale label Dec 15, 2024
@jan-xyz
Copy link

jan-xyz commented Dec 15, 2024

This is still relevant

@github-actions github-actions bot removed the Stale label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: docker Docker containers T: feature-request Requests for new features
Projects
None yet
6 participants