-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for files named Containerfile
rather than Dockerfile
#6067
Comments
An alternate solution would be to allow specification of the full path to the Dockerfile/Containerfile in the dependabot config yaml, rather than specifying the path to the directory that is expected to contain a file named Dockerfile. But this seems like a much broader config change that would impact every ecosystem. Testing for either Dockerfile or Containerfile fits in a narrower scope of just the Though, it still won't fully work for projects that may have multiple different Dockerfiles/Containerfiles for different build profiles. Quarkus, for example, normally has a Dockerfile.jvm and a Dockerfile.native , depending on whether the build produced JVM bytecode or a native image. |
+:100: not even https://docs.docker.com/engine/reference/commandline/build/#specify-a-dockerfile--f |
Ideally we should expose the filename pattern, so people can edit it. Use of Containerfile instead of Dockerfile is very popular and gaining traction as it is brand-agnostic. |
+1 for using alternate names other than |
Let dependabot check for docker dependency updates. This will rename the `Containerfile` to `Dockerfile`, otherwise it won't work, see: dependabot/dependabot-core#6067 --------- Co-authored-by: Bas de Wit <bas@info.nl>
* Improve test-setup.sh for macos - discover broken virtualens (after python upgrade) - implement workaround for building ansible-pylibssh Related: ansible/pylibssh#207 * Make dockerfile dependabot compatible See dependabot/dependabot-core#6067
Previous commit pinned the RockyLinux base image to the latest (at the time of writing) digest. By pinning base images to particular digests we can use dependabot to update the digests whenever a new base image build is available. Unfortunately, dependabot (at the time of writing) doesn't support monitoring of a container instructions document which isn't named "Dockerfile", i.e. the more universal "Containerfile" name isn't supported yet [1]. Therefore, this patch also renames Containerfile to Dockerfile in order to enable dependabot monitoring of this file within github actions. To keep this change from affecting any existing build recipes pointing to a particular file explicitly a "Containerfile" symlink is created as well. [1] dependabot/dependabot-core#6067 Signed-off-by: Erik Skultety <eskultet@redhat.com>
Previous commit pinned the RockyLinux base image to the latest (at the time of writing) digest. By pinning base images to particular digests we can use dependabot to update the digests whenever a new base image build is available. Unfortunately, dependabot (at the time of writing) doesn't support monitoring of a container instructions document which isn't named "Dockerfile", i.e. the more universal "Containerfile" name isn't supported yet [1]. Therefore, this patch also renames Containerfile to Dockerfile in order to enable dependabot monitoring of this file within github actions. To keep this change from affecting any existing build recipes pointing to a particular file explicitly a "Containerfile" symlink is created as well. [1] dependabot/dependabot-core#6067 Signed-off-by: Erik Skultety <eskultet@redhat.com>
Previous commit pinned the RockyLinux base image to the latest (at the time of writing) digest. By pinning base images to particular digests we can use dependabot to update the digests whenever a new base image build is available. Unfortunately, dependabot (at the time of writing) doesn't support monitoring of a container instructions document which isn't named "Dockerfile", i.e. the more universal "Containerfile" name isn't supported yet [1]. Therefore, this patch also renames Containerfile to Dockerfile in order to enable dependabot monitoring of this file within github actions. To keep this change from affecting any existing build recipes pointing to a particular file explicitly a "Containerfile" symlink is created as well. [1] dependabot/dependabot-core#6067 Signed-off-by: Erik Skultety <eskultet@redhat.com>
👋 This issue has been marked as stale because it has been open for 2 years with no activity. You can comment on the issue to hold stalebot off for a while, or do nothing. If you do nothing, this issue will be closed eventually by the stalebot. Please see CONTRIBUTING.md for more policy details. |
This is still relevant |
Is there an existing issue for this?
Feature description
OCI tooling like podman and buildah supports and suggests the more neutral name
Containerfile
. These use the same syntax asDockerfile
. It would be nice if thedocker
ecosystem supported this alternate file name.The text was updated successfully, but these errors were encountered: