Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containerfile is a thing. #11141

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Containerfile is a thing. #11141

merged 1 commit into from
Dec 17, 2024

Conversation

shyouhei
Copy link
Contributor

What are you trying to accomplish?

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@shyouhei shyouhei requested a review from a team as a code owner December 17, 2024 08:05
@github-actions github-actions bot added the L: docker Docker containers label Dec 17, 2024
@shyouhei
Copy link
Contributor Author

I don't think the CI failures are related to this changeset.

@randhircs randhircs requested review from randhircs and removed request for randhircs December 17, 2024 15:18
randhircs
randhircs approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@randhircs randhircs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it, assuming that you have run with containerfile as well.

@randhircs randhircs merged commit d7e0824 into dependabot:main Dec 17, 2024
38 checks passed
@andrewazores andrewazores mentioned this pull request Dec 17, 2024
Closed
@shyouhei shyouhei deleted the containerfile branch December 17, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randhircs randhircs randhircs approved these changes

Assignees
No one assigned
Labels
L: docker Docker containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for files named Containerfile rather than Dockerfile
2 participants
@shyouhei @randhircs