Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker support for Containerfile name #6068

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewazores
Copy link

Fixes #6067

@andrewazores
Copy link
Author

Not really a Rubyist here and not sure how to update the VCR fixtures properly.

@jeffwidman
Copy link
Member

👋 Thanks for putting this up. I keep meaning to review it but just haven't had time yet. One of us will try to get to it in the next few days.

@dhirschfeld
Copy link

Any interest in allowing a full filepath since neither docker nor buildah require any particular naming convention for the file - you can call it whatever you want and point docker/buildah to it with --file

https://docs.docker.com/engine/reference/commandline/build/#specify-a-dockerfile--f

@dhirschfeld
Copy link

My interest in this feature is that I often have multiple dockerfiles alongside each other in the same repository.

I use a meaningful-name.docker convention and name my images after the filename they were created from. It would be great if I could somehow tell dependabot to look for meaningful-name.docker instead of hardcoding Dockerfile.

e.g. maybe something like

updates:
  - package-ecosystem: "docker"
    directory: "/build/docker"
    manifest-name: "meaningful-name.docker"

This could be made backward compatible by having a package-ecosystem default value for manifest-name which is just the existing hardcoded value.

@ssbarnea
Copy link

That also made me curious, is there any YAML file on which dependabot github app can update container versions?

I see that the source code mentions kubernetes YAML files but there is nothing inside the documentation for that.

@sid-maddy
Copy link

Could this PR be picked up for review? AFAICT, it only needs a rebase onto main.

Also, from the comments here and in the linked issue, there seems to be interest in allowing users to provide the manifest names via the Dependabot config file.
AFAICT, this would need changes in docker's file fetcher & updater (my WIP attempt) as well as the logic (not sure where) that parses package manager specific options from the config file.

Could that be included in this PR as well?

@andrewazores
Copy link
Author

Done by #11141 instead

@abdulapopoola abdulapopoola reopened this Dec 17, 2024
@github-actions github-actions bot added the L: docker Docker containers label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: docker Docker containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for files named Containerfile rather than Dockerfile
6 participants