-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker support for Containerfile name #6068
base: main
Are you sure you want to change the base?
Conversation
f255370
to
2051b10
Compare
Not really a Rubyist here and not sure how to update the VCR fixtures properly. |
👋 Thanks for putting this up. I keep meaning to review it but just haven't had time yet. One of us will try to get to it in the next few days. |
Any interest in allowing a full filepath since neither docker nor buildah require any particular naming convention for the file - you can call it whatever you want and point docker/buildah to it with https://docs.docker.com/engine/reference/commandline/build/#specify-a-dockerfile--f |
My interest in this feature is that I often have multiple dockerfiles alongside each other in the same repository. I use a e.g. maybe something like updates:
- package-ecosystem: "docker"
directory: "/build/docker"
manifest-name: "meaningful-name.docker" This could be made backward compatible by having a |
That also made me curious, is there any YAML file on which dependabot github app can update container versions? I see that the source code mentions kubernetes YAML files but there is nothing inside the documentation for that. |
Could this PR be picked up for review? AFAICT, it only needs a rebase onto Also, from the comments here and in the linked issue, there seems to be interest in allowing users to provide the manifest names via the Dependabot config file. Could that be included in this PR as well? |
Done by #11141 instead |
Fixes #6067