Derby 2 #612
Merged
Derby 2 #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use eslint instead of jshint
Fix binding binding.eventmodels initialization
… items The bug was fixed in ba742f6
Update dependencies
Add behavioral test for binding bug with view function calls on array items
Extract browserify code
Derby2 pre-webpack changes
ericyhwang
reviewed
Dec 12, 2022
lib/App.js
Outdated
| @@ -91,6 +104,27 @@ App.prototype._finishInit = function() { | |||
| } | |||
| this.emit('load', page); | |||
| }; | |||
|
|
|||
| App.prototype._isAttached = function isInitialized() { | |||
| const { attached } = globalThis.APPS.get(this.name); | |||
There was a problem hiding this comment.
For now, let's stick with ES5 syntax for consistency with the existing code.
const->var- No object destructuring
lib/App.js
Outdated
| } | ||
|
|
||
| App.prototype._initialState = function initialState() { | ||
| const { initialState } = globalThis.APPS.get(this.name); |
There was a problem hiding this comment.
Same as above, stick with ES5 syntax for now
ericyhwang
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derby 2 extracts bundler code into separate bundler packages to be able to integrate new bundlers (e.g. webpack)
The browserify bundler has been broken out to
derby-browserifypackage and should be included in an app as a plugin like so: