release/v1.0: Decrease rate of Raft heartbeat messages. #3714
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we used to have 20ms ticks, but they would overload the Raft tick channel, causing "A tick missed to fire. Node blocks too long!" logs. Etcd uses 100ms and they haven't seen those issues. Additionally, using 100ms for ticks does not cause proposals to slow down, because they get sent out asap and don't rely on ticks. So, setting this to 100ms instead of 20ms is a NOOP. (cherry picked from commit 4b41d9c)
martinmr
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we used to have 20ms ticks, but they would overload the
Raft tick channel, causing "A tick missed to fire. Node blocks
too long!" logs. Etcd uses 100ms and they haven't seen those
issues. Additionally, using 100ms for ticks does not cause
proposals to slow down, because they get sent out asap and don't
rely on ticks. So, setting this to 100ms instead of 20ms is a
NOOP.
(cherry picked from commit 4b41d9c from master #3708)
This change is