fix(ChannelUpdateAction): emit client event in handle to not miss change #10670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: message forwarding * fix: redundant usage * feat: add additional snapshot fields * refactor: use collection to store snapshots --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* feat: recurring scheduled events * fix: nullable on patch * docs: remove unnecessary parenthesis Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com> --------- Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
* chore: unpin discord-api-types * chore: bump discord-api-types
…ji (discordjs#10477) * types: add ApplicationEmoji to EmojiResolvable * typings: add ApplicationEmoji to MessageReaction#emoji * removed ApplicationEmoji from MessageReaction * update BaseGuildEmojiManager * chore: lint error * feat: add ApplicationEmoji to MessageReaction#emoji getter * refactor: check application emojis first --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…rdjs#10526) * types: remove newMessage partial on messageUpdate event typing * types: omit partial group DM for newMessage on messageUpdate * types: omit partial group DM for oldMessage on messageUpdate --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* fix(GuildScheduledEvent): handle null recurrence_rule * refactor: consistency * feat: implement suggested logic change * fix: correct data.recurrence_rule check --------- Co-authored-by: Almeida <github@almeidx.dev>
* refactor: deprecate fetching user flags * docs: fix reference Co-authored-by: Almeida <github@almeidx.dev> * refactor: use function * refactor: name approach --------- Co-authored-by: Almeida <github@almeidx.dev>
…members (discordjs#10551) * refactor: deprecate `reason` on thread member add and remove * chore: address TSLint errors * refactor: use function
Co-authored-by: Luna <84203950+Wolvinny@users.noreply.github.com>
…iscordjs#10574) * refactor(InteractionResponses): deprecate `ephemeral` response option * refactor: add runtime deprecations * docs: fix reference Co-authored-by: Almeida <github@almeidx.dev> * types: add `MessageFlagsResolvable` --------- Co-authored-by: Almeida <github@almeidx.dev>
* refactor: remove extra traversion * refactor(GuildScheduledEventManager): address fetch
…#10586) * chore(docs): Add note about idempotence to role add/remove routes * chore: remove trailing spaces
* feat: initial support for guild member banners * feat: serialise in `toJSON()` * feat: serialise in `toJSON()` * docs: lowercase i --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…owledged interaction (discordjs#10587) fix: error on deleting response of non-acknowledged interaction Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…#10592) fix(ThreadChannel): address parameter type on fetchOwner()
* feat: Voice Channel Send Effects (discordjs#9288) * feat: add soundboard fields * chore: address TODO * docs: volume is a closed interval * types: use `GatewayVoiceChannelEffectSendDispatchData` * refactor: prefer getting from cache * fix: correctly access cache Co-authored-by: Danial Raza <danialrazafb@gmail.com> --------- Co-authored-by: Danial Raza <danialrazafb@gmail.com>
…#10597) * fix(MessageReaction): `undefined` burst properties * refactor: simpler burst colour check Co-authored-by: Almeida <github@almeidx.dev> --------- Co-authored-by: Almeida <github@almeidx.dev> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
feat: emit reaction type Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
chore: typos Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* feat: add subscriptions * types: fix fetch options types * fix: correct properties in patch method * chore: requested changes Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> * fix: correct export syntax * chore(Entitlement): mark `ends_at` as nullable` * types(FetchSubscriptionOptions): add missing `cache` option * Revert "types(FetchSubscriptionOptions): add missing `cache` option" This reverts commit ba472bd. * chore(Entitlement): mark `startsTimestamp` as nullable * fix: requested changes * docs(SubscriptionManager): correct return type --------- Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
fix: thread owner id is always present Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* feat: support get entitlement * docs: add return type Co-authored-by: Danial Raza <danialrazafb@gmail.com> * fix: property typo Co-authored-by: Almeida <github@almeidx.dev> * fix: property typo Co-authored-by: Almeida <github@almeidx.dev> --------- Co-authored-by: Danial Raza <danialrazafb@gmail.com> Co-authored-by: Almeida <github@almeidx.dev> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* feat(ClientApplication): add webhook events * refactor: update enum names and add external types * docs(APITypes): reorder * chore: requested changes * chore: requested changes * docs: remove redundancy * Update ClientApplication.js --------- Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> Co-authored-by: Almeida <github@almeidx.dev>
build: bump discord-api-types
…scordjs#10626) * refactor: use `cache.get()` for snowflakes, `resolve()` otherwise * fix: requested changes Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> * chore: remove unnecessary `?? null` --------- Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…ring` (discordjs#10625) refactor(FetchApplicationCommandOptions): prefer `Locale`
test: remove unused test Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Apokalypt
requested review from
vladfrangu,
iCrawl,
kyranet and
SpaceEEC
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Jiralite
reviewed
Dec 30, 2024
|
Please set the base branch of this pull request to main. Otherwise, your pull request will just be lost in the future! It will just be backported to v14. |
I close this one and will create a new PR, it will be easier 👍 |
|
New PR : #10690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR corrects the bug reported in #10658 by moving the emission of events inside the action so that no changes are zapped.
Currently, the
<ChannelUpdateAction>.handlemethod is called within theThreadChannelandGuildChannelManagerclasses. This call could result in a modification to the cached instance before the event was received from Discord, causing the event to be lost with the actual modification.Status and versioning classification: