Ddox: Show exact source code links for multiple declarations#1537
Ddox: Show exact source code links for multiple declarations#1537CyberShadow merged 1 commit intodlang:masterfrom
Conversation
|
In case someone was wondering what this does: Beforehttp://dlang.org/library/std/algorithm/comparison/among.html Afterhttp://dtest.thecybershadow.net/artifact/website-99c70ce923b2fb7f7dfc8aec6a9d04c3a5f1406f-b7c033f85ecbb7d3947e28b0db7d1c5e/web/library-prerelease/std/algorithm/comparison/among.html |
|
I think this is a really trivial change (one char!) that sits here for more than a month. @CyberShadow could you please help and have a look? |
CyberShadow
left a comment
There was a problem hiding this comment.
Sure why not. Not familiar with the code but the diff looks fine to me.
|
Hmm this had the disadvantage that it creates a huge diff for even small changes as all line numbers are shifted. Should we for Digger builds turn this off? |
|
Link to example diff? |
Digger builds the live website which would mean they would almost never be visible there. I guess you meant DAutoTest. We already do this for |
If there are multiple declarations, the source code link should go to the first declaration - not to the header of the file.
Example e.g.: http://dlang.org/library/std/algorithm/comparison/among.html