Skip to content

Ddox: Show exact source code links for multiple declarations#1537

Merged
CyberShadow merged 1 commit intodlang:masterfrom
wilzbach:fix-source-code-links-ddox
Feb 14, 2017
Merged

Ddox: Show exact source code links for multiple declarations#1537
CyberShadow merged 1 commit intodlang:masterfrom
wilzbach:fix-source-code-links-ddox

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Dec 27, 2016

If there are multiple declarations, the source code link should go to the first declaration - not to the header of the file.

Example e.g.: http://dlang.org/library/std/algorithm/comparison/among.html

@wilzbach
Copy link
Contributor Author

I think this is a really trivial change (one char!) that sits here for more than a month. @CyberShadow could you please help and have a look?

Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure why not. Not familiar with the code but the diff looks fine to me.

@CyberShadow CyberShadow merged commit 2b7ad8f into dlang:master Feb 14, 2017
@wilzbach wilzbach deleted the fix-source-code-links-ddox branch February 14, 2017 08:00
@wilzbach
Copy link
Contributor Author

Hmm this had the disadvantage that it creates a huge diff for even small changes as all line numbers are shifted. Should we for Digger builds turn this off?

@CyberShadow
Copy link
Member

Link to example diff?

@CyberShadow
Copy link
Member

Should we for Digger builds turn this off?

Digger builds the live website which would mean they would almost never be visible there. I guess you meant DAutoTest. We already do this for NODATETIME.

@wilzbach
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants