Skip to content

Better diff mode (DIFFABLE=1)#1588

Merged
CyberShadow merged 2 commits intodlang:masterfrom
wilzbach:better-diff-mode
Feb 27, 2017
Merged

Better diff mode (DIFFABLE=1)#1588
CyberShadow merged 2 commits intodlang:masterfrom
wilzbach:better-diff-mode

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Feb 27, 2017

Follow-up to dlang/tools#222 and #1537

Btw as this could also lead to unrelated diffs, should we disable the Bugzilla query for bugs for the changelog builder in "nightly mode"?

Hmm, yeah, changes that shouldn't result in documentation changes should not have documentation changes indicated in the status line, because then inadvertent documentation changes will get through. I guess with this and #1537 we should expand NODATETIME to something more generic.

| http://digitalmars.com
- import std.process : environment;
- string version_id = environment["GIT_TARGET"];
- bool noExactSourceCodeLinks = environment["NO_EXACT_SOURCE_CODE_LINKS"] == "1";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently that's the "workaround" to inject parameters into the layout file - it's also the prevalent style here (see above).

@CyberShadow
Copy link
Member

[2017-02-27 09:13:16.384055] Running: 'make' '-f' 'posix.mak' 'DIFFABLE=1' 'all' 'kindle' 'pdf' 'verbatim'

Seems to be working from my side :)

@CyberShadow
Copy link
Member

Relevant change: CyberShadow/ae@a313457

@CyberShadow
Copy link
Member

Why the broken "Previous version.html" link? Will that be resolved by dlang/tools#222?

@wilzbach
Copy link
Contributor Author

Why the broken "Previous version.html" link? Will that be resolved by dlang/tools#222?

Good catch!
It's due to the changed.d trying to detect the previous version based on the git revision pattern, which isn't passed anymore. Luckily there's the --prev-version flag (fixed).

@CyberShadow CyberShadow merged commit c9b3bd3 into dlang:master Feb 27, 2017
@wilzbach wilzbach deleted the better-diff-mode branch February 27, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants