Skip to content

Use alternative header for nightly builds#222

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:emit-nightly-header
Mar 1, 2017
Merged

Use alternative header for nightly builds#222
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:emit-nightly-header

Conversation

@wilzbach
Copy link
Contributor

I didn't realize that when we provide different Makefile targets (with BUILD_NIGHTLY) we can override even more logic :)

@CyberShadow
Copy link
Member

How weird that this is causing a diff in the autotester.

It seems DDox has a race condition or something regarding which homonym symbol it chooses to link to.

@wilzbach
Copy link
Contributor Author

How weird that this is causing a diff in the autotester.

Btw as this could also lead to unrelated diffs, should we disable the Bugzilla query for bugs for the changelog builder in "nightly mode"?

@CyberShadow
Copy link
Member

Hmm, yeah, changes that shouldn't result in documentation changes should not have documentation changes indicated in the status line, because then inadvertent documentation changes will get through. I guess with this and dlang/dlang.org#1537 we should expand NODATETIME to something more generic.

@CyberShadow
Copy link
Member

If you want to update the posix.mak side I'll update DAutoTest. I'm thinking a DIFFABLE makefile parameter which will automatically enable NODATETIME and the other stuff.

@wilzbach
Copy link
Contributor Author

If you want to update the posix.mak side I'll update DAutoTest. I'm thinking a DIFFABLE makefile parameter which will automatically enable NODATETIME and the other stuff.

Alrighty :)

@wilzbach
Copy link
Contributor Author

Alrighty :)

-> dlang/dlang.org#1588

@CyberShadow
Copy link
Member

I understand this change will never be visible in the documentation tester because it applies to the Bugzilla header.

@dlang-bot dlang-bot merged commit f6a185b into dlang:master Mar 1, 2017
@wilzbach wilzbach deleted the emit-nightly-header branch March 1, 2017 08:24
@wilzbach
Copy link
Contributor Author

wilzbach commented Mar 1, 2017

I understand this change will never be visible in the documentation tester because it applies to the Bugzilla header.

Well in theory it will be visible, e.g. here:
http://dlang.org/changelog/2.074.0.html

But of course only if the --nightly mode is enabled:

dlang/dlang.org#1586

@CyberShadow
Copy link
Member

Right, I meant the documentation tester specifically (because we excluded Bugzilla entries when DIFFABLE is on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants