Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase stable #16962

Closed
wants to merge 300 commits into from
Closed

Rebase stable #16962

wants to merge 300 commits into from

Conversation

thewilsonator
Copy link
Contributor

No description provided.

dkorpel and others added 30 commits October 7, 2024 13:13
@dkorpel @thewilsonator
Fix bugzilla 24645 - Hidden static assert error messages if more than…
390a6c7 
… 20 errors
@0-v-0 @thewilsonator
add const for toString() method (dlang#16685)
634de74 
* add const for toString() method

* fix error
@thewilsonator
Actually give deprecation for -noboundscheck (dlang#16687)
18d5920 
This has been deprecated for at least 7 years...
@0-v-0 @thewilsonator
use enum instead of immutable for CTFE-only literals (dlang#16670)
29697cd 
* use enum instead of immutable

* disable enum_array_literal_check for dmd.astbase
@tim-dlang @thewilsonator
Fix bugzilla 24660 - atomic_wchar_t has wrong size on Posix (dlang#16688
9e98481 
)
@tim-dlang @thewilsonator
Fix bugzilla 24661 - wctype_t and wctrans_t are platform-dependent
914cf9d 
The previous definitions are left as the default. They could still
be wrong on some other platforms.
@dkorpel @thewilsonator
Refactor -deps and -makedeps code into its own module (dlang#16686)
efb220a 
* Refactor -deps and -makedeps code into its own module

* Destructure Params more in dmd.deps
@dkorpel @thewilsonator
Remove @trusted: on top of dmacro.d (dlang#16690)
17a5441
@WalterBright @thewilsonator
refactor elf.obj_mangle2() (dlang#16691)
3b9a3f8
@WalterBright @thewilsonator
minor refactor of cpp_mangle2() (dlang#16692)
bd871f3
@0-v-0 @thewilsonator
refactor nested reference checking (dlang#16693)
4fa8f11
@anitahammer @thewilsonator
[druntime] fix doc link in core.stdcpp.string_view (dlang#16696)
61c1d63
@WalterBright @thewilsonator
change many regm_t *pretregs to ref regm_t pretregs (dlang#16698)
e55f130
@dkorpel @thewilsonator
Merge escapeByValue and escapeByRef for CallExp
9277a78
@dkorpel @thewilsonator
Extract escapeCallExp and use it for escapeByRef
1c8e37a
@WalterBright @thewilsonator
cgxmm.d to ref pretregs
72efbea
@WalterBright @thewilsonator
purge reg_t *pretregs from cg87.d
d3a81c3
@denizzzka @thewilsonator
rt.cover: unused extern symbol removed (dlang#16704)
c30a5c5
@dkorpel @thewilsonator
Reduce duplication in escapeCallExp (dlang#16703)
7cb529d
@WalterBright @thewilsonator
fix ref pretregs in cod4.d (dlang#16712)
c6db1b2
@0-v-0 @thewilsonator
[refactor] remove redundant code (dlang#16714)
7761c82 
* remove redundant code

* remove redundant attributes
@dkorpel @thewilsonator
escape.d: Fix handling of isTypesafeVariadicArray (dlang#16709)
fe40396
@WalterBright @thewilsonator
cod1.d: many pointers to ref (dlang#16713)
5f4d153
@ntrel @thewilsonator
[ddoc] Show TypeCtor method attributes after parameters (dlang#16708)
3f734a0 
This is more readable.
@dkorpel @thewilsonator
Fix bugzilla 24663 - dip1000 doesn't check slice expression implicitl…
771db79 
…y converted to static array (dlang#16705)
@dkorpel @thewilsonator
escape.d: remove dead isTypesafeVariadicArray branches (dlang#16710)
a131623
@dkorpel @thewilsonator
escape.d: Merge escapeByValue and escapeByRef (dlang#16715)
f0ea782
@0-v-0 @thewilsonator
simplify nested reference checking
e844897
@0-v-0 @thewilsonator
remove redundant attributes
e307131
@0-v-0 @thewilsonator
fix error
506af51
WalterBright and others added 22 commits October 7, 2024 13:27
@WalterBright @thewilsonator
improve logic in isCopyConstructable()
20debb4
@thewilsonator
[func.d] move errorSupplementalInferredAttr to expressionsem.d
725d880 
all but one of its uses are there, the other is in `canthrow.d`
@dchidindu5 @thewilsonator
Move newScope out of AST nodes to dsymbolsem.d (dlang#16880)
d4a0921
@thewilsonator
Update dsymbol.h (dlang#16938)
735a813
@thewilsonator
TemplateInstance.equalsx use early return (dlang#16940)
c2758eb
@thewilsonator
move isSafe/setUnsafe to safe.d (dlang#16871)
0378814
@thewilsonator
[dimport.d] move addAlias to parser, remove import dmd.errors (dl…
f8295ac 
…ang#16935)
@thewilsonator
[declaration.d] don't void init ulongs (dlang#16943)
eb2d9ca
@thewilsonator
use selective imports for dsymbolsem in ATS node files (dlang#16950)
5fe0a9d 
The goal is to remove all semantic imports from AST node files. This makes it obvious what still needs to be done.
@thewilsonator
[dtemplate.d] use early returns (dlang#16946)
0d806ed
@thewilsonator
move checkPrintfScanfSignature to funcsem.d make private (dlang#1…
e46a820 
…6951)
@thewilsonator
Remove unused PASSenum from header (dlang#16948)
68f143b 
LDC and GDC use the `enum class`.
@thewilsonator
[declaration.d] move checkDisabled and expandInitializer to expre…
36ffcff 
…ssionsem.d (dlang#16941)
@thewilsonator
[expressionsem.d] make some functions private (dlang#16954)
f39fb9a
@thewilsonator
[dclass.d] restrict semantic imports (dlang#16956)
37a0ddb
@thewilsonator
dotTemplateSemanticProp use nested function (dlang#16955)
6a1377d 
instead of `goto`
@thewilsonator
[func.d] move overloadApply to funcsem.d, remove unused imports (d…
a73631f 
…lang#16949)
@thewilsonator
Fix visibility deprecation (dlang#16957)
bee2041
@thewilsonator
move dummyArg to templatesem.d make private (dlang#16945)
2cfb60f
@thewilsonator
Update doc comment for checkNestedReference(FuncDeclaration)
f502502 
it was disrupted by dlang#16286
@thewilsonator
Rename the FuncDeclaration overload of checkNestedReference
860c243 
To distinguish it from the `VarDeclaration` overload that does something quite different.
@thewilsonator
move needsTypeInference to expressionsem.d make private
21cc7f1
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 24645 enhancement Hidden static assert error messages if more than 20 errors
✓ 24660 normal atomic_wchar_t has wrong size on Posix
✓ 24661 normal wctype_t and wctrans_t are platform-dependent
✓ 24663 normal dip1000 doesn't check slice expression implicitly converted to static array

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16962"

@thewilsonator
Copy link
Contributor Author

Hmm, maybe I did this the wrong way around...

@thewilsonator thewilsonator deleted the rebase-stable branch October 7, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuclaw ibuclaw Awaiting requested review from ibuclaw ibuclaw is a code owner

Assignees
No one assigned
Labels
Bug Fix Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.