Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Aug 28, 2019

Followup to #2647, #2644, #2643, #2634, #2763, #2765, and #2766

This is a continuation of work to clean up object.d.

The runtime hooks are only used by the compiler and should not be invoked directly by the user. This PR moves them to the bottom of object.d's file so they appear last in the documentation. _cmp had to be moved too due to a bug in the compiler causing a conflict with core.internal.array.comparison.__cmp.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2768"

public import core.internal.switch_: __switch_error;

// Compare class and interface objects for ordering.
private int __cmp(Obj)(Obj lhs, Obj rhs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like another candidate for moving to core.internal.

foreach_reverse (ref T e; a)
e.__xdtor();
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it makes sense to add a big comment along the lines of:

//******************
//* Runtime Hooks: *
//******************

To better designate the file structure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants