Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Aug 27, 2019

Followup to #2647, #2644, #2643, and #2634

This is a continuation of work to clean up object.d and bring some older conventions in line with the current trends. There's no change in functionality; this PR has only moved code to a new file and renamed arrayOp to _arrayOp to avoid needing a forwarding template.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2763"

@JinShil
Copy link
Contributor Author

JinShil commented Aug 27, 2019

This should be ready to go now. For some reason renaming from arrayOp to _arrayOp caused 32-bit platforms to fail in core.internal.simd. So I removed it for now. I'll address it in a followup PR where I can deal with it in isolation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants