Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Aug 28, 2019

Followup to #2647, #2644, #2643, #2634, #2763, #2765, and #2766

This is a continuation of work to clean up object.d.

This code was added in #2638, but it doesn't currently appear to be used anywhere.

During the GSoC 2019 project for converting some runtime hooks to templates, we decided that we should be using the naming convention _d_whatever for any runtime templates such as this. That naming convention is already the dominant convention in druntime, so it makes sense to keep it. It also distinguishes runtime hooks from compiler-generated symbols that are prefixed with __. A few of the templates don't follow the _d_ convention, but I intend to remedy that with a later PR so all are consistent.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2769"

@JinShil JinShil changed the title Move __move_post_blt to from object.d to core.internal.moving.d and rename it to _d_movePostblit Move __move_post_blt from object.d to core.internal.moving.d and rename it to _d_movePostblit Aug 28, 2019
@JinShil JinShil changed the title Move __move_post_blt from object.d to core.internal.moving.d and rename it to _d_movePostblit Move __move_post_blt from object.d to core.internal.moving.d Aug 28, 2019
@JinShil
Copy link
Contributor Author

JinShil commented Aug 28, 2019

It appears code in Phobos calls this directly, so I reverted the rename.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants