Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Aug 27, 2019

Followup to #2647, #2644, #2643, #2634, #2763, and #2765

This is a continuation of work to clean up object.d

@JinShil JinShil marked this pull request as ready for review August 27, 2019 17:36
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2766"

@CyberShadow
Copy link
Member

All these object.d refactorings do seem to have a measurable effect on compilation times:
https://perf.dlang.io/#program-empty-compile-realtime-10;program-empty-compile-callgrind-insns;1560217958.0705755;1567251986

However, the cost is very small - merely two milliseconds.

@JinShil
Copy link
Contributor Author

JinShil commented Aug 31, 2019

For instruction count, I see the bump, but for real time, there seems to be a lot of noise, and I don't think it's possible to say one way or another. For example, there was a bump in real time for this PR, but all I did was delete code.

@CyberShadow
Copy link
Member

Measuring CPU time is always going to be imprecise, however we can still see that the time is increasing (compare visually the left side and right side of the chart at that link). To find the cause why CPU time has increased, we can use a synthetic but exact metric which is generally directly correlated with it (in this case, # of instructions executed as reported by Callgrind). Using this method we can see that the execution time was increased by this & similar recent PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants