Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove all class props from all components #3634

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

AadneRo
Copy link
Contributor

@AadneRo AadneRo commented May 31, 2024

didn't include Logo or PaymentCard, working on these in different PRs

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 10:43am

Copy link

codesandbox-ci bot commented May 31, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@AadneRo AadneRo force-pushed the chore/remoce-all-class-props branch from 27130ab to a53a33d Compare May 31, 2024 10:16
@AadneRo AadneRo requested a review from tujoworker May 31, 2024 10:33
@tujoworker tujoworker requested review from joakbjerk and removed request for tujoworker June 3, 2024 08:10
Copy link
Contributor

@joakbjerk joakbjerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🔥

@AadneRo AadneRo merged commit 274b648 into main Jun 4, 2024
10 checks passed
@AadneRo AadneRo deleted the chore/remoce-all-class-props branch June 4, 2024 08:26
tujoworker added a commit that referenced this pull request Jun 4, 2024
tujoworker added a commit that referenced this pull request Jun 4, 2024
tujoworker added a commit that referenced this pull request Jun 4, 2024
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.34.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

langz pushed a commit that referenced this pull request Jul 1, 2024
…nents (#3745)

Since the usage of `class` is documented in Button, Drawer, Dialog and
Modal, we bring back a deprecated version of it.

The overall support was removed in this PR: #3634
tujoworker pushed a commit that referenced this pull request Jul 5, 2024
## [10.39.0](v10.38.0...v10.39.0) (2024-07-05)

### 🐛 Bug Fixes

* deprecate `class` prop in Button, Drawer, Dialog and Modal components ([#3745](#3745)) ([2aea682](2aea682)), closes [#3634](#3634)
* **Forms:** update `emptyValue` documentation and type to reflect how it's used internally  ([#3729](#3729)) ([ff755e7](ff755e7))
* **PaymentCard:** change SBanken to Sbanken ([#3747](#3747)) ([bfe8a9d](bfe8a9d))
* **PaymentCard:** set sbanken MC code to P103 ([#3746](#3746)) ([1e97a41](1e97a41))

### 📝 Documentation

* **Field.Number:** add `allowNegative` demo/example ([#3754](#3754)) ([d6d3dbd](d6d3dbd))
* **Field.Number:** fix `percent` demo/example ([#3755](#3755)) ([c1a0839](c1a0839))

### ✨ Features

* **Field.Number:** add `allowNegative` mask prop ([#3753](#3753)) ([9dc1358](9dc1358))
* **Field.Number:** add `disallowLeadingZeroes` prop ([#3756](#3756)) ([d49cad9](d49cad9))
* **Table:** add navigation mode ([#3752](#3752)) ([b3a6db9](b3a6db9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants