Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PaymentCard): change SBanken to Sbanken #3747

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

thaytharma
Copy link
Contributor

  • changed SBanken to Sbanken
  • added proper brand name for Sbanken: 'Sbanken – et konsept fra DNB'

@thaytharma thaytharma requested a review from langz June 30, 2024 10:09
Copy link

vercel bot commented Jun 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2024 10:22am

@thaytharma thaytharma changed the title fix(PaymentCard): Change SBanken to Sbanken fix(PaymentCard): change SBanken to Sbanken Jun 30, 2024
 - changed SBanken to Sbanken
 - added proper brand name for Sbanken: 'Sbanken – et konsept fra DNB'
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great.
I'll take a closer look at it tomorrow. I see there's a failing visual test(atleast when I approved the PR), it could be random, or that we just have to update the test.

🫡

@thaytharma thaytharma merged commit bfe8a9d into main Jul 1, 2024
10 checks passed
@thaytharma thaytharma deleted the fix/cards-sbanken branch July 1, 2024 05:52
tujoworker pushed a commit that referenced this pull request Jul 5, 2024
## [10.39.0](v10.38.0...v10.39.0) (2024-07-05)

### 🐛 Bug Fixes

* deprecate `class` prop in Button, Drawer, Dialog and Modal components ([#3745](#3745)) ([2aea682](2aea682)), closes [#3634](#3634)
* **Forms:** update `emptyValue` documentation and type to reflect how it's used internally  ([#3729](#3729)) ([ff755e7](ff755e7))
* **PaymentCard:** change SBanken to Sbanken ([#3747](#3747)) ([bfe8a9d](bfe8a9d))
* **PaymentCard:** set sbanken MC code to P103 ([#3746](#3746)) ([1e97a41](1e97a41))

### 📝 Documentation

* **Field.Number:** add `allowNegative` demo/example ([#3754](#3754)) ([d6d3dbd](d6d3dbd))
* **Field.Number:** fix `percent` demo/example ([#3755](#3755)) ([c1a0839](c1a0839))

### ✨ Features

* **Field.Number:** add `allowNegative` mask prop ([#3753](#3753)) ([9dc1358](9dc1358))
* **Field.Number:** add `disallowLeadingZeroes` prop ([#3756](#3756)) ([d49cad9](d49cad9))
* **Table:** add navigation mode ([#3752](#3752)) ([b3a6db9](b3a6db9))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants