Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate class prop in Button, Drawer, Dialog and Modal components #3745

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

tujoworker
Copy link
Member

Since the usage of class is documented in Button, Drawer, Dialog and Modal, we bring back a deprecated version of it.

The overall support was removed in this PR: #3634

@tujoworker tujoworker requested a review from langz June 28, 2024 12:41
Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 0:47am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@langz langz merged commit 2aea682 into main Jul 1, 2024
15 checks passed
@langz langz deleted the fix/revert-class-prop branch July 1, 2024 08:32
tujoworker pushed a commit that referenced this pull request Jul 5, 2024
## [10.39.0](v10.38.0...v10.39.0) (2024-07-05)

### 🐛 Bug Fixes

* deprecate `class` prop in Button, Drawer, Dialog and Modal components ([#3745](#3745)) ([2aea682](2aea682)), closes [#3634](#3634)
* **Forms:** update `emptyValue` documentation and type to reflect how it's used internally  ([#3729](#3729)) ([ff755e7](ff755e7))
* **PaymentCard:** change SBanken to Sbanken ([#3747](#3747)) ([bfe8a9d](bfe8a9d))
* **PaymentCard:** set sbanken MC code to P103 ([#3746](#3746)) ([1e97a41](1e97a41))

### 📝 Documentation

* **Field.Number:** add `allowNegative` demo/example ([#3754](#3754)) ([d6d3dbd](d6d3dbd))
* **Field.Number:** fix `percent` demo/example ([#3755](#3755)) ([c1a0839](c1a0839))

### ✨ Features

* **Field.Number:** add `allowNegative` mask prop ([#3753](#3753)) ([9dc1358](9dc1358))
* **Field.Number:** add `disallowLeadingZeroes` prop ([#3756](#3756)) ([d49cad9](d49cad9))
* **Table:** add navigation mode ([#3752](#3752)) ([b3a6db9](b3a6db9))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants