Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PaymentCard): set sbanken MC code to P103 #3746

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

haigol
Copy link
Contributor

@haigol haigol commented Jun 28, 2024

The previous sourceProductCode was wrong for Sbanken-cards. This one should be correct.

Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 8:15am

Copy link

codesandbox-ci bot commented Jun 28, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@langz langz changed the title Fix wrong sbanken MC product code fix(PaymentCard): wrong sbanken MC product code Jun 28, 2024
@langz langz force-pushed the fix/payment-card-wrong-product-code-sbanken branch from 66c1e32 to 0bb804d Compare July 1, 2024 07:16
Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great :)

I rebased this branch with main branch, as there was some conflict with changes done in #3747

I also updated a screenshot test in the following commit e1ff369

@langz langz changed the title fix(PaymentCard): wrong sbanken MC product code fix(PaymentCard): set sbanken MC code to P103 Jul 1, 2024
@langz langz merged commit 1e97a41 into main Jul 1, 2024
9 of 10 checks passed
@langz langz deleted the fix/payment-card-wrong-product-code-sbanken branch July 1, 2024 08:19
tujoworker pushed a commit that referenced this pull request Jul 5, 2024
## [10.39.0](v10.38.0...v10.39.0) (2024-07-05)

### 🐛 Bug Fixes

* deprecate `class` prop in Button, Drawer, Dialog and Modal components ([#3745](#3745)) ([2aea682](2aea682)), closes [#3634](#3634)
* **Forms:** update `emptyValue` documentation and type to reflect how it's used internally  ([#3729](#3729)) ([ff755e7](ff755e7))
* **PaymentCard:** change SBanken to Sbanken ([#3747](#3747)) ([bfe8a9d](bfe8a9d))
* **PaymentCard:** set sbanken MC code to P103 ([#3746](#3746)) ([1e97a41](1e97a41))

### 📝 Documentation

* **Field.Number:** add `allowNegative` demo/example ([#3754](#3754)) ([d6d3dbd](d6d3dbd))
* **Field.Number:** fix `percent` demo/example ([#3755](#3755)) ([c1a0839](c1a0839))

### ✨ Features

* **Field.Number:** add `allowNegative` mask prop ([#3753](#3753)) ([9dc1358](9dc1358))
* **Field.Number:** add `disallowLeadingZeroes` prop ([#3756](#3756)) ([d49cad9](d49cad9))
* **Table:** add navigation mode ([#3752](#3752)) ([b3a6db9](b3a6db9))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants