Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Forms): update emptyValue documentation and type to reflect how it's used internally #3729

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

joakbjerk
Copy link
Contributor

@joakbjerk joakbjerk commented Jun 25, 2024

  • Add value type to emptyValue in documentation
  • Add tests to verify that the allowed 'emptyValue' works
  • Update types to reflect these changes

@joakbjerk joakbjerk requested review from langz and tujoworker June 25, 2024 06:14
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 8:44am

@joakbjerk joakbjerk removed request for langz and tujoworker June 25, 2024 06:26
@joakbjerk joakbjerk marked this pull request as draft June 25, 2024 06:26
@joakbjerk joakbjerk changed the title fix(Forms): allow for any type for emptyValue as stated in documentation fix(Forms): update documentation and emptyValue type to be more specific Jun 25, 2024
Copy link

codesandbox-ci bot commented Jun 28, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@joakbjerk joakbjerk force-pushed the fix/field-emptyvalue-type branch from ad87cca to b3723e8 Compare July 2, 2024 08:37
@joakbjerk joakbjerk requested a review from langz July 2, 2024 10:25
@joakbjerk joakbjerk changed the title fix(Forms): update documentation and emptyValue type to be more specific fix(Forms): update emptyValue documentation and type to be more specific Jul 2, 2024
@joakbjerk joakbjerk changed the title fix(Forms): update emptyValue documentation and type to be more specific fix(Forms): update emptyValue documentation and type to reflect how it's used internally Jul 2, 2024
@joakbjerk joakbjerk merged commit ff755e7 into main Jul 2, 2024
10 checks passed
@joakbjerk joakbjerk deleted the fix/field-emptyvalue-type branch July 2, 2024 10:39
tujoworker pushed a commit that referenced this pull request Jul 5, 2024
## [10.39.0](v10.38.0...v10.39.0) (2024-07-05)

### 🐛 Bug Fixes

* deprecate `class` prop in Button, Drawer, Dialog and Modal components ([#3745](#3745)) ([2aea682](2aea682)), closes [#3634](#3634)
* **Forms:** update `emptyValue` documentation and type to reflect how it's used internally  ([#3729](#3729)) ([ff755e7](ff755e7))
* **PaymentCard:** change SBanken to Sbanken ([#3747](#3747)) ([bfe8a9d](bfe8a9d))
* **PaymentCard:** set sbanken MC code to P103 ([#3746](#3746)) ([1e97a41](1e97a41))

### 📝 Documentation

* **Field.Number:** add `allowNegative` demo/example ([#3754](#3754)) ([d6d3dbd](d6d3dbd))
* **Field.Number:** fix `percent` demo/example ([#3755](#3755)) ([c1a0839](c1a0839))

### ✨ Features

* **Field.Number:** add `allowNegative` mask prop ([#3753](#3753)) ([9dc1358](9dc1358))
* **Field.Number:** add `disallowLeadingZeroes` prop ([#3756](#3756)) ([d49cad9](d49cad9))
* **Table:** add navigation mode ([#3752](#3752)) ([b3a6db9](b3a6db9))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants