Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): add navigation mode #3752

Merged
merged 4 commits into from
Jul 5, 2024
Merged

feat(Table): add navigation mode #3752

merged 4 commits into from
Jul 5, 2024

Conversation

langz
Copy link
Contributor

@langz langz commented Jul 2, 2024

Navigation Table looks like this:
Screenshot 2024-07-02 at 16 11 12

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 8:24am

@langz langz force-pushed the feat/table-navigation-mode branch from 3c98ae3 to 7c31fd0 Compare July 2, 2024 14:10
Copy link

codesandbox-ci bot commented Jul 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@langz langz force-pushed the feat/table-navigation-mode branch from 7c31fd0 to c20c7f1 Compare July 2, 2024 14:17
@langz langz marked this pull request as ready for review July 2, 2024 15:34
@langz
Copy link
Contributor Author

langz commented Jul 2, 2024

@dsa015, we have started implementing what we believe you want/need.
It would be great if you can set aside a few minutes to test it and provide feedback, so that we know if we are moving in the correct direction 🫡

Demos/docs can be seen here:
https://eufemia-git-feat-table-navigation-mode-eufemia.vercel.app/uilib/components/table/#table-with-navigation

Press the «Code»-button to be able to explore and edit the code and example.

@dsa015
Copy link
Contributor

dsa015 commented Jul 2, 2024

@langz this is great! This addresses our current design perfectly! 👍

Copy link
Contributor

@joakbjerk joakbjerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🔥 Looks good to me ⭐️

packages/dnb-eufemia/src/components/table/Table.tsx Outdated Show resolved Hide resolved
packages/dnb-eufemia/src/components/table/TableDocs.ts Outdated Show resolved Hide resolved
langz and others added 3 commits July 5, 2024 10:08
Co-authored-by: Joakim Bjerknes <joakbjerk@gmail.com>
Co-authored-by: Joakim Bjerknes <joakbjerk@gmail.com>
@langz langz merged commit b3a6db9 into main Jul 5, 2024
10 checks passed
@langz langz deleted the feat/table-navigation-mode branch July 5, 2024 08:45
tujoworker pushed a commit that referenced this pull request Jul 5, 2024
## [10.39.0](v10.38.0...v10.39.0) (2024-07-05)

### 🐛 Bug Fixes

* deprecate `class` prop in Button, Drawer, Dialog and Modal components ([#3745](#3745)) ([2aea682](2aea682)), closes [#3634](#3634)
* **Forms:** update `emptyValue` documentation and type to reflect how it's used internally  ([#3729](#3729)) ([ff755e7](ff755e7))
* **PaymentCard:** change SBanken to Sbanken ([#3747](#3747)) ([bfe8a9d](bfe8a9d))
* **PaymentCard:** set sbanken MC code to P103 ([#3746](#3746)) ([1e97a41](1e97a41))

### 📝 Documentation

* **Field.Number:** add `allowNegative` demo/example ([#3754](#3754)) ([d6d3dbd](d6d3dbd))
* **Field.Number:** fix `percent` demo/example ([#3755](#3755)) ([c1a0839](c1a0839))

### ✨ Features

* **Field.Number:** add `allowNegative` mask prop ([#3753](#3753)) ([9dc1358](9dc1358))
* **Field.Number:** add `disallowLeadingZeroes` prop ([#3756](#3756)) ([d49cad9](d49cad9))
* **Table:** add navigation mode ([#3752](#3752)) ([b3a6db9](b3a6db9))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants