Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form.Section.EditContainer validation issues #3797

Closed
andlbrei opened this issue Aug 8, 2024 · 2 comments · Fixed by #3853
Closed

Form.Section.EditContainer validation issues #3797

andlbrei opened this issue Aug 8, 2024 · 2 comments · Fixed by #3853
Labels
bug Something isn't working released

Comments

@andlbrei
Copy link
Contributor

andlbrei commented Aug 8, 2024

🐛 Bug Report

Form.Section.EditContainer validation does not always work.

I have come across two issues which is shown in this reproduction:

  • When the edit container is opened and the user attempts to finish without doing any changes, leaving the required fields blank, the user is allowed to do so. Attempting to go to the next page will trigger validation, and force the user to fill in the required fields.
  • Cancelling editing after having removed text in a required field is allowed by the container, and the blank field is stored. Again, trying to progress in the form will trigger a validation error. Going by this reproduction, this only happens on nested paths.
Screen.Recording.2024-08-08.at.08.11.36.mov

To Reproduce

In this reproduction step 1 will demonstrate no validation on cancel and step 2 will have working cancel.
In step 1 the containers are within a Form.Section with a set path, while in step 2 they are within a Form.Section with no path.

https://codesandbox.io/p/sandbox/nested-section-validation-issue-6mrxmv?file=%2Fsrc%2FApp.tsx%3A50%2C9

Expected behavior

I expect validation to be triggered when finishing changes, even if the user has made no changes.
I expect cancelling to restore the data that was stored when the user opened the section for editing.

Eufemia Version

10.42.0

@tujoworker tujoworker added the bug Something isn't working label Aug 8, 2024
@tujoworker
Copy link
Member

The first issue is fixed in this PR #3851

tujoworker pushed a commit that referenced this issue Aug 26, 2024
## [10.45.0](v10.44.0...v10.45.0) (2024-08-26)

### 📝 Documentation

* **Upload:** adds `false` as a file max size type ([#3846](#3846)) ([8747e74](8747e74))

### 🐛 Bug Fixes

* **forms:** enhance `Field.Name` validation rule ([#3849](#3849)) ([9c9142d](9c9142d))
* **forms:** ensure `Iterate.Array` can handle an array given in the data context ([#3842](#3842)) ([263f4c7](263f4c7)), closes [#3759](#3759)
* **forms:** ensure `Section.EditContainer` cancel restores data when path is given ([#3853](#3853)) ([eabc583](eabc583)), closes [#3797](#3797)
* **forms:** ensure pressing enter in an input field inside Wizard does trigger next step ([#3852](#3852)) ([fd35828](fd35828))
* **forms:** make `Form.Isolation`s data flow "from outside" stricter ([#3847](#3847)) ([977962b](977962b)), closes [#3844](#3844)
* **forms:** validate fields inside `Iterate.EditContainer` when done button is pressed ([#3850](#3850)) ([2a2272e](2a2272e))
* **forms:** validate fields inside `Section.EditContainer` when done button is pressed ([#3851](#3851)) ([1c34980](1c34980))
* **useTheme:** define the return type of `null` as a possible return ([#3861](#3861)) ([8d0cf61](8d0cf61))

### ✨ Features

* **forms:** add `inheritLabel` prop to value components ([#3858](#3858)) ([01e0976](01e0976))
* **forms:** add `Iterate.PushContainer` to support an "initially open" container ([#3843](#3843)) ([0fe23a9](0fe23a9))
* **forms:** add `Value.ArraySelection` component ([#3854](#3854)) ([bc55cc2](bc55cc2))
* **forms:** add `Value.Selection` component ([#3857](#3857)) ([7432986](7432986))
* **forms:** add support for `{itemNr}` to the iterate container title + add `useItem` hook ([#3848](#3848)) ([0d50272](0d50272))
* **Upload:** define max file size for file type ([#3859](#3859)) ([13fc1a8](13fc1a8))
@tujoworker
Copy link
Member

🎉 This issue has been resolved in version 10.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
2 participants