Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form.Isolation defaultData overriden by Form.Handler data on useState re-render #3844

Closed
andlbrei opened this issue Aug 20, 2024 · 1 comment · Fixed by #3847
Closed

Form.Isolation defaultData overriden by Form.Handler data on useState re-render #3844

andlbrei opened this issue Aug 20, 2024 · 1 comment · Fixed by #3847
Labels
released

Comments

@andlbrei
Copy link
Contributor

🐛 Bug Report

When a useState set function is called the data from Form.Handler seems to override defaultData set on Form.Isolation.

Screen.Recording.2024-08-20.at.08.43.56.mov

To Reproduce

https://codesandbox.io/p/sandbox/form-isolation-defaultdata-usestate-r2slx6

Steps to reproduce the behavior:

Have a Form.Handler with data and a child Form.Isolation with some other defaultData and some set function which is used when a Field changes it's value.
When the component re-renders the value from Form.Handler data will override the inner Form.Isolation defaultData.

Expected behavior

I expect values from Form.Handler to not have any impact in Form.Isolation when Form.Isolation defaultData i set.

Eufemia Version

10.44.0
@andlbrei andlbrei changed the title Form.Isolation defaultData + useState = problem Form.Isolation defaultData overriden by Form.Handler data on useState re-render Aug 20, 2024
@tujoworker tujoworker mentioned this issue Aug 20, 2024
Merged
tujoworker added a commit that referenced this issue Aug 20, 2024
@tujoworker
fix(forms): make Form.Isolations data flow "from outside" stricter (#…
977962b 
…3847)

Fixes #3844

The test fails with the old implementation 👍
tujoworker pushed a commit that referenced this issue Aug 26, 2024
@semantic-release-bot
chore(release): 10.45.0 [skip ci]
bbacae5 
## [10.45.0](v10.44.0...v10.45.0) (2024-08-26)

### 📝 Documentation

* **Upload:** adds `false` as a file max size type ([#3846](#3846)) ([8747e74](8747e74))

### 🐛 Bug Fixes

* **forms:** enhance `Field.Name` validation rule ([#3849](#3849)) ([9c9142d](9c9142d))
* **forms:** ensure `Iterate.Array` can handle an array given in the data context ([#3842](#3842)) ([263f4c7](263f4c7)), closes [#3759](#3759)
* **forms:** ensure `Section.EditContainer` cancel restores data when path is given ([#3853](#3853)) ([eabc583](eabc583)), closes [#3797](#3797)
* **forms:** ensure pressing enter in an input field inside Wizard does trigger next step ([#3852](#3852)) ([fd35828](fd35828))
* **forms:** make `Form.Isolation`s data flow "from outside" stricter ([#3847](#3847)) ([977962b](977962b)), closes [#3844](#3844)
* **forms:** validate fields inside `Iterate.EditContainer` when done button is pressed ([#3850](#3850)) ([2a2272e](2a2272e))
* **forms:** validate fields inside `Section.EditContainer` when done button is pressed ([#3851](#3851)) ([1c34980](1c34980))
* **useTheme:** define the return type of `null` as a possible return ([#3861](#3861)) ([8d0cf61](8d0cf61))

### ✨ Features

* **forms:** add `inheritLabel` prop to value components ([#3858](#3858)) ([01e0976](01e0976))
* **forms:** add `Iterate.PushContainer` to support an "initially open" container ([#3843](#3843)) ([0fe23a9](0fe23a9))
* **forms:** add `Value.ArraySelection` component ([#3854](#3854)) ([bc55cc2](bc55cc2))
* **forms:** add `Value.Selection` component ([#3857](#3857)) ([7432986](7432986))
* **forms:** add support for `{itemNr}` to the iterate container title + add `useItem` hook ([#3848](#3848)) ([0d50272](0d50272))
* **Upload:** define max file size for file type ([#3859](#3859)) ([13fc1a8](13fc1a8))
@tujoworker
Copy link
Member

🎉 This issue has been resolved in version 10.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(forms): make Form.Isolations data flow "from outside" stricter dnbexperience/eufemia
2 participants
@tujoworker @andlbrei