Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forms): add Iterate.PushContainer to support an "initially open" container #3843

Merged
merged 7 commits into from
Aug 20, 2024
Merged

feat(forms): add Iterate.PushContainer to support an "initially open" container #3843

merged 7 commits into from
Aug 20, 2024

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Aug 19, 2024 •
edited
Loading

Quick example:

<Iterate.Array path="/accounts">
  <MyViewItem />
  <MyEditItem />
</Iterate.Array>

<Iterate.PushContainer
  path="/accounts"
  title="New account holder"
  openButton={
    <Iterate.PushContainer.OpenButton text="Add another account" />
  }
  showOpenButtonWhen={(list) => list.length > 0}
>
  <MyEditItemForm />
</Iterate.PushContainer>

@vercel Vercel
Copy link

vercel bot commented Aug 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 9:55am

@tujoworker tujoworker force-pushed the feat/iterate-create-container branch from d340780 to 38e31ff Compare August 19, 2024 16:57
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Aug 19, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker tujoworker force-pushed the feat/iterate-create-container branch from 38e31ff to 3978a4c Compare August 19, 2024 18:51
@tujoworker tujoworker force-pushed the feat/iterate-create-container branch from 3978a4c to 28d09aa Compare August 19, 2024 19:25
@tujoworker tujoworker force-pushed the feat/iterate-create-container branch from 28d09aa to 54df91f Compare August 19, 2024 19:37
@tujoworker tujoworker force-pushed the feat/iterate-create-container branch from 54df91f to dabd4aa Compare August 19, 2024 19:48
@tujoworker tujoworker force-pushed the feat/iterate-create-container branch 2 times, most recently from 65d2005 to f3a4845 Compare August 20, 2024 04:30
@tujoworker tujoworker force-pushed the feat/iterate-create-container branch from f3a4845 to c7bb75b Compare August 20, 2024 04:34
@tujoworker tujoworker requested a review from langz August 20, 2024 06:49
langz
langz approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I've demoed/tested the examples provided, and looked through the code 🫡

packages/dnb-eufemia/src/extensions/forms/constants/locales/nb-NO.ts Outdated Show resolved Hide resolved
...b-design-system-portal/src/docs/uilib/extensions/forms/Iterate/CreateEntryContainer/info.mdx Outdated Show resolved Hide resolved
...b-design-system-portal/src/docs/uilib/extensions/forms/Iterate/CreateEntryContainer/info.mdx Outdated Show resolved Hide resolved
@tujoworker tujoworker changed the title feat(forms): add Iterate.CreateEntryContainer to support an "initially open" container feat(forms): add Iterate.PushContainer to support an "initially open" container Aug 20, 2024
@tujoworker tujoworker force-pushed the feat/iterate-create-container branch from a24ae23 to 7f1f8b1 Compare August 20, 2024 09:43
@tujoworker tujoworker merged commit 0fe23a9 into main Aug 20, 2024
10 checks passed
@tujoworker tujoworker deleted the feat/iterate-create-container branch August 20, 2024 10:55
joakbjerk pushed a commit that referenced this pull request Aug 21, 2024
@tujoworker @langz @joakbjerk
feat(forms): add Iterate.PushContainer to support an "initially ope…
b36f9c3 
…n" container (#3843)

Co-authored-by: Anders <anderslangseth@gmail.com>
tujoworker pushed a commit that referenced this pull request Aug 26, 2024
@semantic-release-bot
chore(release): 10.45.0 [skip ci]
bbacae5 
## [10.45.0](v10.44.0...v10.45.0) (2024-08-26)

### 📝 Documentation

* **Upload:** adds `false` as a file max size type ([#3846](#3846)) ([8747e74](8747e74))

### 🐛 Bug Fixes

* **forms:** enhance `Field.Name` validation rule ([#3849](#3849)) ([9c9142d](9c9142d))
* **forms:** ensure `Iterate.Array` can handle an array given in the data context ([#3842](#3842)) ([263f4c7](263f4c7)), closes [#3759](#3759)
* **forms:** ensure `Section.EditContainer` cancel restores data when path is given ([#3853](#3853)) ([eabc583](eabc583)), closes [#3797](#3797)
* **forms:** ensure pressing enter in an input field inside Wizard does trigger next step ([#3852](#3852)) ([fd35828](fd35828))
* **forms:** make `Form.Isolation`s data flow "from outside" stricter ([#3847](#3847)) ([977962b](977962b)), closes [#3844](#3844)
* **forms:** validate fields inside `Iterate.EditContainer` when done button is pressed ([#3850](#3850)) ([2a2272e](2a2272e))
* **forms:** validate fields inside `Section.EditContainer` when done button is pressed ([#3851](#3851)) ([1c34980](1c34980))
* **useTheme:** define the return type of `null` as a possible return ([#3861](#3861)) ([8d0cf61](8d0cf61))

### ✨ Features

* **forms:** add `inheritLabel` prop to value components ([#3858](#3858)) ([01e0976](01e0976))
* **forms:** add `Iterate.PushContainer` to support an "initially open" container ([#3843](#3843)) ([0fe23a9](0fe23a9))
* **forms:** add `Value.ArraySelection` component ([#3854](#3854)) ([bc55cc2](bc55cc2))
* **forms:** add `Value.Selection` component ([#3857](#3857)) ([7432986](7432986))
* **forms:** add support for `{itemNr}` to the iterate container title + add `useItem` hook ([#3848](#3848)) ([0d50272](0d50272))
* **Upload:** define max file size for file type ([#3859](#3859)) ([13fc1a8](13fc1a8))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tujoworker tujoworker mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langz langz langz approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tujoworker @langz