fix(forms): enhance Field.Name validation rule

[tujoworker]

const validNames = [
  'Ole',
  'Anne-Marie',
  'Hans Christian',
  'Åse',
  'Müller',
  'García-López',
  'Frédéric-Jean',
]

const invalidNames = [
  'Ole1',
  'Hans  Christian',
  'Anne--Marie',
  '@nna',
  'Ole--',
  'Liv-',
  ' Martin',
  'Anders ',
]

it.each(validNames)('Valid name: %s', (name) => {
  render(<Field.Name validateInitially value={name} />)
  expect(screen.queryByRole('alert')).not.toBeInTheDocument()
})

it.each(invalidNames)('Invalid name: %s', (name) => {
  render(<Field.Name validateInitially value={name} />)
  expect(screen.queryByRole('alert')).toBeInTheDocument()
  expect(screen.queryByRole('alert')).toHaveTextContent(
    nb.Field.errorPattern
  )
})

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eufemia	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 20, 2024 7:17pm

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[langz]

Looks fine to me 👍

I don't 100% understand the validation rule, or why we want/need validation rules for names. Does it exist a rule for how a name could look like? Is it the government who decides this? Is it different from country to country? Or perhaps its DNB who wants these rules for names? 🤔

[tujoworker]

We had a very weak check. The new regex is still not very strict, but as you can see in the tests, it takes care of obvious wrongly written names.
I don't think there is the perfect validation for names. But I think this brings us a long way. And yes, the change is made from feedback by the Trident team. That said, they used a much stricter regex.

[langz]

We had a very weak check. The new regex is still not very strict, but as you can see in the tests, it takes care of obvious wrongly written names.

I don't think there is the perfect validation for names. But I think this brings us a long way. And yes, the change is made from feedback by the Trident team. That said, they used a much stricter regex.

Thanks for the explanation🫡

[tujoworker]

🎉 This PR is included in version 10.45.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀