Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forms): add Value.Selection component #3857

Merged
merged 14 commits into from
Aug 26, 2024
Merged

feat(forms): add Value.Selection component #3857

merged 14 commits into from
Aug 26, 2024

Conversation

joakbjerk
Copy link
Contributor

@joakbjerk joakbjerk commented Aug 21, 2024 •
edited by tujoworker
Loading

  • Fix and update tests
  • Improve and fix Value rendering

Quick example:

<Form.Handler
  data={{
    selection: 'bar',
    myList: [
      { value: 'foo', title: 'Foo' },
      { value: 'bar', title: 'Bar' },
      { value: 'baz', title: 'Baz' },
    ],
  }}
>
  <Flex.Stack>
    <Field.Selection
      path="/selection"
      dataPath="/myList"
      variant="radio"
      label="My selection"
    />
    <Value.Selection
      path="/selection"
      dataPath="/myList"
      inheritLabel
    />
  </Flex.Stack>
</Form.Handler>

@vercel Vercel
Copy link

vercel bot commented Aug 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 8:14am

@joakbjerk joakbjerk requested review from tujoworker and langz August 21, 2024 12:49
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Aug 21, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker tujoworker changed the title feat(Value): add Selection component feat(forms): add Value.Selection component Aug 22, 2024
@joakbjerk joakbjerk force-pushed the feat/value-selection branch from 77a61f7 to 086f45c Compare August 22, 2024 13:03
@joakbjerk joakbjerk marked this pull request as draft August 23, 2024 06:16
@joakbjerk joakbjerk marked this pull request as ready for review August 23, 2024 08:56
@joakbjerk joakbjerk force-pushed the feat/value-selection branch from 4dd3f61 to 05071ec Compare August 23, 2024 10:54
tujoworker
tujoworker approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work 🚀

packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Value/Selection/info.mdx Outdated Show resolved Hide resolved
packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Value/Selection.mdx Outdated Show resolved Hide resolved
joakbjerk and others added 2 commits August 23, 2024 14:14
@joakbjerk @tujoworker
Update packages/dnb-design-system-portal/src/docs/uilib/extensions/fo…
4ba79c7 
…rms/Value/Selection/info.mdx

Co-authored-by: Tobias Høegh <tobias@tujo.no>
@joakbjerk @tujoworker
Update packages/dnb-design-system-portal/src/docs/uilib/extensions/fo…
74d2824 
…rms/Value/Selection.mdx

Co-authored-by: Tobias Høegh <tobias@tujo.no>
@tujoworker tujoworker force-pushed the feat/value-selection branch from c623e7e to 5b8b130 Compare August 23, 2024 16:11
@tujoworker tujoworker mentioned this pull request Aug 26, 2024
Merged
@tujoworker tujoworker merged commit 7432986 into main Aug 26, 2024
10 checks passed
@tujoworker tujoworker deleted the feat/value-selection branch August 26, 2024 08:28
langz
langz approved these changes Aug 26, 2024
View reviewed changes
packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/Value/Selection.mdx Show resolved Hide resolved
packages/dnb-eufemia/src/extensions/forms/Value/Selection/SelectionDocs.ts

export const SelectionProperties: PropertiesTableProps = {
dataPath: {
doc: 'The path to the context data (Form.Handler). The object needs to have a `value` and a `title` property. The generated options will be placed above given JSX based children.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
doc: 'The path to the context data (Form.Handler). The object needs to have a `value` and a `title` property. The generated options will be placed above given JSX based children.',
doc: 'The path to the context data (Form.Handler). The context data object needs to have a `value` and a `title` property. The generated options will be placed above given JSX based children.',

When reading this in the dos, I don't 100% get it.

tujoworker pushed a commit that referenced this pull request Aug 26, 2024
@semantic-release-bot
chore(release): 10.45.0 [skip ci]
bbacae5 
## [10.45.0](v10.44.0...v10.45.0) (2024-08-26)

### 📝 Documentation

* **Upload:** adds `false` as a file max size type ([#3846](#3846)) ([8747e74](8747e74))

### 🐛 Bug Fixes

* **forms:** enhance `Field.Name` validation rule ([#3849](#3849)) ([9c9142d](9c9142d))
* **forms:** ensure `Iterate.Array` can handle an array given in the data context ([#3842](#3842)) ([263f4c7](263f4c7)), closes [#3759](#3759)
* **forms:** ensure `Section.EditContainer` cancel restores data when path is given ([#3853](#3853)) ([eabc583](eabc583)), closes [#3797](#3797)
* **forms:** ensure pressing enter in an input field inside Wizard does trigger next step ([#3852](#3852)) ([fd35828](fd35828))
* **forms:** make `Form.Isolation`s data flow "from outside" stricter ([#3847](#3847)) ([977962b](977962b)), closes [#3844](#3844)
* **forms:** validate fields inside `Iterate.EditContainer` when done button is pressed ([#3850](#3850)) ([2a2272e](2a2272e))
* **forms:** validate fields inside `Section.EditContainer` when done button is pressed ([#3851](#3851)) ([1c34980](1c34980))
* **useTheme:** define the return type of `null` as a possible return ([#3861](#3861)) ([8d0cf61](8d0cf61))

### ✨ Features

* **forms:** add `inheritLabel` prop to value components ([#3858](#3858)) ([01e0976](01e0976))
* **forms:** add `Iterate.PushContainer` to support an "initially open" container ([#3843](#3843)) ([0fe23a9](0fe23a9))
* **forms:** add `Value.ArraySelection` component ([#3854](#3854)) ([bc55cc2](bc55cc2))
* **forms:** add `Value.Selection` component ([#3857](#3857)) ([7432986](7432986))
* **forms:** add support for `{itemNr}` to the iterate container title + add `useItem` hook ([#3848](#3848)) ([0d50272](0d50272))
* **Upload:** define max file size for file type ([#3859](#3859)) ([13fc1a8](13fc1a8))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tujoworker tujoworker tujoworker approved these changes

@langz langz langz approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joakbjerk @tujoworker @langz